Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix package lock and typos after #7890 #10304

Merged
merged 1 commit into from
Oct 3, 2018
Merged

Fix package lock and typos after #7890 #10304

merged 1 commit into from
Oct 3, 2018

Conversation

ellatrix
Copy link
Member

@ellatrix ellatrix commented Oct 3, 2018 •
edited
Loading

Description

  1. Fixes the package lock. No idea why it changed here: 94352e7#diff-32607347f8126e6534ebc7ebaec4853d
  2. Search-replace typo: 94352e7#r30727710
  3. Adjust instance of "record" where we otherwise refer to the object as "value" in the rest of the package.

How has this been tested?

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

@ellatrix ellatrix added this to the 4.0 milestone Oct 3, 2018
@ellatrix ellatrix requested a review from gziolo October 3, 2018 13:49
@ellatrix ellatrix mentioned this pull request Oct 3, 2018
Merged
4 tasks
tofumatt
tofumatt approved these changes Oct 3, 2018
View reviewed changes
Copy link
Member

@tofumatt tofumatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me!

package-lock.json
@@ -2415,6 +2415,7 @@
"version": "file:packages/rich-text",
"requires": {
"@babel/runtime": "^7.0.0",
"@wordpress/escape-html": "file:packages/escape-html",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was probably just something that someone forgot to merge, I saw it in another PR I reviewed recently too (
https://github.com/WordPress/gutenberg/pull/10295/files#r222124781)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I’m that person :)

@ellatrix
Copy link
Member Author

ellatrix commented Oct 3, 2018

Thanks Matt!

@ellatrix ellatrix merged commit 4691baf into master Oct 3, 2018
@tofumatt tofumatt deleted the fix/package-lock-typo-rich-text branch October 3, 2018 17:53
@tofumatt tofumatt mentioned this pull request Oct 3, 2018
Merged
4 tasks
@ellatrix ellatrix mentioned this pull request Oct 3, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tofumatt tofumatt tofumatt approved these changes

@gziolo gziolo Awaiting requested review from gziolo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ellatrix @tofumatt