Move embed scripts into the body in preview documents #10434
Conversation
There was a problem hiding this comment.
I hate to be that person, but is there any chance this could be something we have an E2E test for? I'm not sure how easy it'd be to test the embed appearing or the enabling of the Jetpack plugin without an account. I guess it might be a pain, but this seems a good candidate for something we could easily regress in the future.
Code makes sense to me though. If a test is too much of a pain, maybe you could add a comment about the reason the code is in the body and not the head? I could imagine someone in the future thinking they're clever and moving it back out! 😅
|
@tofumatt I'll add a comment :) And everyone has permission to buy a giant foam bat with "embed e2e" tests written on to bop me on the head with. They are coming. |
|
OMG now I want that bat for everyone! 😆 |
Description
Jetpack supplies embeds that use shortcodes, and enqueue scripts needed for the embeds to work. We were including these scripts in
<head>but that doesn't work for all embeds. This change moves them into the body of the preview document, which fixes issues with Instagram embeds.How has this been tested?
Install Jetpack and make sure the shortcode module is enabled.
In a new post, embed https://www.pinterest.co.uk/pin/373869206564305678/ and https://www.instagram.com/p/BoEH8K_lCJ4/?taken-by=juicedpixels
Both should show a preview of the embed.
Types of changes
Bug fix