Move embed scripts into the body in preview documents #10434
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Jetpack supplies embeds that use shortcodes, and enqueue scripts needed for the embeds to work. We were including these scripts in
<head>
but that doesn't work for all embeds. This change moves them into the body of the preview document, which fixes issues with Instagram embeds.How has this been tested?
Install Jetpack and make sure the shortcode module is enabled.
In a new post, embed https://www.pinterest.co.uk/pin/373869206564305678/ and https://www.instagram.com/p/BoEH8K_lCJ4/?taken-by=juicedpixels
Both should show a preview of the embed.
Types of changes
Bug fix