Detect oEmbed responses where the oEmbed provider has gone away #10467
Conversation
There was a problem hiding this comment.
Seems legit, but the steps to test here read like they'd make an excellent E2E test. Is it possible to add an HTML page that would allow an oEmbed we could use to test (so the tests didn't require an outside connection)? If so that's worth adding (I guess even an HTML copy of a page with valid oEmbed data.)
If this isn't urgent I'd say we should add tests before merging. If it's urgent I'll cave 😉
|
@tofumatt agreed, I'm writing the E2E test now. I'll put this as In Progress and add it to this PR. |
|
To test as much as possible, we need to at least make the call to the embed proxy endpoint. I've added an e2e test that intercepts it and returns html that won't cause errors in the console, in the same way we have to for the demo page test. The new e2e test makes sure that the embed block switches to the correct block based on the URL, aspect ratio class is applied to the embed with a fixed height/width iframe, and that embeds that can't be embedded end up back in the edit state. |
notnownikki
removed
the
[Status] In Progress
|
e2e test is in this PR now |
| }; | ||
|
|
||
| const addEmbeds = async () => { | ||
| await newPost(); |
There was a problem hiding this comment.
I might move this to setUp(), but that's about it.
| @@ -0,0 +1,130 @@ | |||
| /** | |||
There was a problem hiding this comment.
The "blocks" folder didn't exist at the time these tests were introduced, but at this point this file would be better placed as specs/blocks/embed.test.js.
Description
Some embed providers still listed in core's allowed list are no longer valid. Either the third party's API endpoint has changed, or support has been removed completely.
In these cases, oEmbed returns a different response, and doesn't do the link fallback behaviour. This PR updates for those cases.
Also, it moves the logic of what is a valid preview and what couldn't be embedded out of the edit component.
How has this been tested?
Try to embed the following URLs where oEmbed has an incorrect API endpoint for the provider:
http://i294.photobucket.com/albums/mm102/magiciansteven/hel512_22.jpg
https://www.reverbnation.com/collection/186-mellow-beats
https://www.amazon.com/Maxboost-Protector-Tempered-Advanced-Accurate/dp/B073DLZWX7
You should see the "can't be embedded" message,
Try to embed this WordPress page that can't be embedded:
https://wordpress.org/gutenberg/handbook/
You should see the "can't be embedded" message,
Try to embed this invalid Twitter URL:
http://twitter.com/ufidosufdisofudisoufio
You should see the "can't be embedded" message,
Embed this valid URL:
https://twitter.com/notnownikki
Types of changes
Bug Fix
Checklist: