render_block_core_latest_posts() Add filter for The block attributes

[ghost]

Description

Add a filter so that plugins and themes can filter the block attributes.

Why is this needed.

Plugins may want to filter attributes in some situations. Eg. WPML will need to display posts in the current language only.

How has this been tested?

This has been tested with WPML using the following code example.

add_filter( 'render_block_core_latest_posts_attributes', 'render_block_core_latest_posts_attributes_filter' );
function render_block_core_latest_posts_attributes_filter( $attributes ) {
   $attributes['suppress_filters'] = false;
   return $attributes;
}

Types of changes

Add a new filter

Checklist:

• My code is tested.
• My code follows the WordPress code style.
• My code follows the accessibility standards.
• My code has proper inline documentation.

[andreasciamanna]

Will this change be included in WP 5.0?

[swissspidy]

Shouldn't this be covered by #11730?

[youknowriad]

I think there's already a filter for the render_callback that is generic (across all blocks), I feel adding a specific filter like this is just a duplication.

[youknowriad]

see #11523

[ghost]

@youknowriad @swissspidy it's little different because suppress_filters it's not a Gutenberg block attribute by default

[youknowriad]

It is different, but you can achieve the same use-cases, maybe it's a bit more difficult in some cases and a bit easier in others.

[ghost]

@youknowriad I can filter $attributes array with 'render_block' filter but there no way to pass suppress_filters to wp_get_recent_posts there

[youknowriad]

Can't you just regenerate the HTML output of the block the way you want?

[swissspidy]

That sounds a bit hacky though, especially since the block HTML output could change.

Why does the block even use wp_get_recent_posts? A regular WP_Query would have been just fine. This way one doesn't have to work around suppress_filters limitations.

[andreasciamanna]

I was wondering the same @swissspidy

I never saw a report from users complaining that the results of wp_get_recent_posts weren't filtered (WPML filters all queries when they deal with translatable post types), which makes me wonder how many themes use this function.

Anyway, if it should use wp_get_recent_posts, wouldn't make more sense to have a filter inside this function, instead of render_block_core_latest_posts?

[ghost]

added https://core.trac.wordpress.org/ticket/45349 for adding filter inside wp_get_recent_posts instead

[gziolo]

I think it duplicates efforts started in #11730 which tries to be more generic. There is also a similar proposal which tries to modify a single attribute for Reusable block block: #8912.

[ghost]

@youknowriad @gziolo is it ok if I modify pull request and replace wp_get_recent_posts on regular WP_Query like @swissspidy proposed?

[swissspidy]

Probably easier to do that in a separate PR as it's a totally different approach.

[gziolo]

I'm closing this one in favor of #11730, which tries to do the same but for all blocks. This is example from the mentioned PR:

add_filter( 'block_prepared_attributes', 'block_attributes_filter', 1, 10 );
function block_attributes_filter( $attributes, $block_type ) {
    if ( $block_type->name === 'my-plugin/my-block' &&  isset( $attributes['data'] ) ) {
            $original_post_id = apply_filters( 'wpml_object_id', get_the_ID(), get_post_type(), true, apply_filters( 'wpml_default_language', null) );
            foreach ( $attributes['data'] as $name => $value ) {
                $string_name = WPML_Gutenberg_Strings_In_Block::get_string_id($attributes['name'], $value);
                $translated = apply_filters( 'wpml_translate_string',
                    $value,
                    $string_name,
                    array('kind' => 'Gutenberg', 'name' => $original_post_id) );
                $attributes['data'][$name] = $translated;
            }
        }

        return $attributes;
}