Add: Generic end 2 end test to the block transforms. #12336

jorgefilipecosta · 2018-11-26T22:45:32Z

Description

This is a second try on PR #10536, after a recommendation by @gziolo to try to make the PR smaller so it becomes easier to review.
In order to make the PR smaller, I temporarily created a list of test fixtures that intersects with the set of all fixtures so most fixtures are ignored. Another PR will follow that corrects the fixtures (mainly media ones) so they are reliable and can be used in this tests (e.g: don't trigger 404 requests).
All the mechanisms are present in this PR the only change that will happen in the other PR is the removal of the intersection and its list, the update of some media fixtures and the creation of new snapshots.

This is a high-level test that is going to Guarantee that every possible transform on Gutenberg is tested and works as expected (the result matches the save snapshot).

How has this been tested?

Verify all test cases pass.

gziolo

This PR needs to be refreshed since tests were moved to the new folder. I should have time next week to perform proper review of this PR if it updated :)

gziolo · 2019-02-24T15:55:34Z

Is it still blocked given that we merged #13658 a few days ago?

jorgefilipecosta · 2019-02-24T22:43:40Z

Hi @gziolo,
This PR was updated taking into account the last changes and it ready for a new review.

I'm on vacation this week and I don't want to block anyone else from reviewing and merging this one :)

jorgefilipecosta · 2019-03-22T09:51:12Z

This PR is rebased and updated I think it is ready for the last checkup before the merge.

packages/e2e-tests/fixtures/block-transforms.js

ellatrix · 2019-03-22T13:22:45Z

packages/e2e-tests/specs/__snapshots__/block-transforms.test.js.snap

@@ -0,0 +1,183 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[`test transforms individual transforms work as expected Code block should transform to Preformatted block. fixture: core__code 1`] = `


This doesn't read very well. Ideally, it should be a readable sentence. E.g. RichText should insert character.

Is there any way to remove or reduce test transforms individual transforms work as expected ?

gziolo · 2019-03-22T13:51:40Z

packages/e2e-tests/specs/block-transforms.test.js

+			await page.click( '.editor-post-title .editor-post-title__block' );
+		} );
+
+		for ( const [ fixture, { originalBlock, availableTransforms } ] of Object.entries( EXPECTED_TRANSFORMS ) ) {


There is describe.each API method, which you might also want to use here: https://jestjs.io/docs/en/api#describeeachtable-name-fn-timeout

It wouldn't have to be expressed using all those loops.

gziolo · 2019-03-22T13:53:56Z

packages/e2e-test-utils/src/get-block-title.js

+ *
+ * @return {Promise} Promise resolving with a string containing the block title.
+ */
+export async function getBlockTitle( blockName ) {


How about making it more generic: getBlockSetting( blockName, settingName )?

Another idea, what if we create a wrapper over data API? It might not scale to keep creating helpers each time we want to get some data from the store.

jorgefilipecosta · 2019-03-22T16:29:45Z

Thank you for the reviews @gziolo and @ellatrix, I applied the feedback before the merge.

gziolo · 2019-03-22T18:12:54Z

packages/e2e-tests/specs/block-transforms.test.js

+			)
+		);
+
+		it.each( testTable )(


Awesome, looks great 👍

gziolo · 2019-03-25T08:59:26Z

I'm seeing the following error after rebasing my PR:

FAIL specs/block-transforms.test.js (27.737s)
  ● Block transforms › should contain the expected transforms
    expect(jest.fn()).not.toHaveErrored(expected)
    Expected mock function not to be called but it was called with:
    ["Block validation: Block validation failed for `%s` (%o).
    Content generated by `save` function:
    %s
    Content retrieved from post body:
    %s core/shortcode JSHandle@object  [gallery ids=\"238,338\"]"]
      at expect (../jest-console/build/@wordpress/jest-console/src/index.js:34:4)
  ● Block transforms › should contain the expected transforms
    expect(jest.fn()).not.toHaveWarned(expected)
    Expected mock function not to be called but it was called with:
    ["Block validation: Expected end of content, instead saw %o. JSHandle@object"]
      at expect (../jest-console/build/@wordpress/jest-console/src/index.js:34:4)

https://travis-ci.com/WordPress/gutenberg/jobs/187395326#L1050

gziolo · 2019-03-25T09:02:28Z

I think I know what has happened :)
The issue is that we still don't override PHP file of dynamic blocks and the change I introduced doesn't load attributes of Shortcode block properly. You can skip it :)

jorgefilipecosta · 2019-03-25T10:06:12Z

I think I know what has happened :)
The issue is that we still don't override PHP file of dynamic blocks and the change I introduced doesn't load attributes of Shortcode block properly. You can skip it :)

I guess this was the first problem this tests caught, it is a good sign :)

jorgefilipecosta mentioned this pull request Nov 26, 2018

Add generic end 2 end test to all block transforms #10536

Closed

jorgefilipecosta force-pushed the add/generic-end-2-end-test-block-transforms branch 2 times, most recently from c86eed0 to b7c0a55 Compare November 27, 2018 21:40

jorgefilipecosta requested a review from a team November 28, 2018 14:57

gziolo added the [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. label Jan 31, 2019

gziolo previously requested changes Jan 31, 2019

View reviewed changes

jorgefilipecosta mentioned this pull request Feb 4, 2019

Refactor: Move block fixtures to e2e-tests package #13658

Merged

gziolo added this to the 5.2 (Gutenberg) milestone Feb 7, 2019

jorgefilipecosta added the [Status] Blocked Used to indicate that a current effort isn't able to move forward label Feb 13, 2019

gziolo removed this from the 5.2 (Gutenberg) milestone Feb 18, 2019

jorgefilipecosta force-pushed the add/generic-end-2-end-test-block-transforms branch from b7c0a55 to b2d1c3d Compare February 24, 2019 22:21

jorgefilipecosta requested review from aduth, ajitbohra, nerrad, ntwb, talldan and youknowriad as code owners February 24, 2019 22:21

jorgefilipecosta removed the [Status] Blocked Used to indicate that a current effort isn't able to move forward label Feb 24, 2019

jorgefilipecosta requested a review from gziolo February 24, 2019 22:44

gziolo added this to the 5.3 (Gutenberg) milestone Feb 25, 2019

gziolo added the [Feature] Block Transforms Block transforms from one block to another label Feb 25, 2019

jorgefilipecosta modified the milestones: 5.3 (Gutenberg), 5.4 (Gutenberg) Mar 14, 2019

jorgefilipecosta force-pushed the add/generic-end-2-end-test-block-transforms branch 2 times, most recently from 7021600 to ea59dfc Compare March 20, 2019 09:53

ellatrix reviewed Mar 22, 2019

View reviewed changes

packages/e2e-tests/fixtures/block-transforms.js Show resolved Hide resolved

ellatrix reviewed Mar 22, 2019

View reviewed changes

ellatrix approved these changes Mar 22, 2019

View reviewed changes

gziolo reviewed Mar 22, 2019

View reviewed changes

jorgefilipecosta force-pushed the add/generic-end-2-end-test-block-transforms branch from ea59dfc to e5f6171 Compare March 22, 2019 15:38

Add: Generic end 2 end test to the block transforms.

79d5a5f

jorgefilipecosta force-pushed the add/generic-end-2-end-test-block-transforms branch from e5f6171 to 79d5a5f Compare March 22, 2019 15:46

jorgefilipecosta merged commit f4de109 into master Mar 22, 2019

jorgefilipecosta deleted the add/generic-end-2-end-test-block-transforms branch March 22, 2019 16:29

gziolo reviewed Mar 22, 2019

View reviewed changes

packages/e2e-tests/specs/block-transforms.test.js

)

);

it.each( testTable )(

Copy link

Member

gziolo Mar 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, looks great 👍

This was referenced Apr 1, 2019

Bump plugin version to 5.4.0-rc.1 #14735

Merged

Bump plugin version to 5.4.0 #14783

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add: Generic end 2 end test to the block transforms. #12336

Add: Generic end 2 end test to the block transforms. #12336

jorgefilipecosta commented Nov 26, 2018 •

edited

Loading

gziolo left a comment

gziolo commented Feb 24, 2019

jorgefilipecosta commented Feb 24, 2019

jorgefilipecosta commented Mar 22, 2019

ellatrix Mar 22, 2019

ellatrix Mar 22, 2019

gziolo Mar 22, 2019

gziolo Mar 22, 2019

jorgefilipecosta commented Mar 22, 2019

gziolo Mar 22, 2019

gziolo commented Mar 25, 2019

gziolo commented Mar 25, 2019

jorgefilipecosta commented Mar 25, 2019

		@@ -0,0 +1,183 @@
		// Jest Snapshot v1, https://goo.gl/fbAQLP

		exports[`test transforms individual transforms work as expected Code block should transform to Preformatted block. fixture: core__code 1`] = `

Add: Generic end 2 end test to the block transforms. #12336

Add: Generic end 2 end test to the block transforms. #12336

Conversation

jorgefilipecosta commented Nov 26, 2018 • edited Loading

Description

How has this been tested?

gziolo left a comment

Choose a reason for hiding this comment

gziolo commented Feb 24, 2019

jorgefilipecosta commented Feb 24, 2019

jorgefilipecosta commented Mar 22, 2019

ellatrix Mar 22, 2019

Choose a reason for hiding this comment

ellatrix Mar 22, 2019

Choose a reason for hiding this comment

gziolo Mar 22, 2019

Choose a reason for hiding this comment

gziolo Mar 22, 2019

Choose a reason for hiding this comment

jorgefilipecosta commented Mar 22, 2019

gziolo Mar 22, 2019

Choose a reason for hiding this comment

gziolo commented Mar 25, 2019

gziolo commented Mar 25, 2019

jorgefilipecosta commented Mar 25, 2019

jorgefilipecosta commented Nov 26, 2018 •

edited

Loading