-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct the docs manifest #12411
Correct the docs manifest #12411
Conversation
…Importer can't handle that.
… altered slightly from WordPress@a0a6349
0570a49
to
7dddeab
Compare
Oh @dd32 you are my hero. I’ll review this today! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks great to me. I have some clarifying questions but this should definitely land as-is — you know this infrastructure better than me! ❤️
This all makes sense and obviously based on the live handbook it works really well! It's not clear yet if we will end up adding the I'm happy to help with the cleanup on .org but I don't have access there right now. In the future, if I expect a docs change to cause problems on import (moving an item between children, renaming something, etc.) should I just mention you, or ask for access myself? |
Restarted Travis… it's an e2e failure so totally unrelated to these changes. |
…rnmobile/danilo-try-to-fix-undo-redo * 'master' of https://github.com/WordPress/gutenberg: Autocompleters: Consider block category (#12287) Only init TinyMCE once per instance (#12386) RichText: convert HTML formatting whitespace to spaces (#12166) Notices: Remove "files" block in package.json (#12438) Edit Post: Avoid rendering AdminNotices compatibility component (#12444) Correct the docs manifest (#12411)
…HEAD * 'master' of https://github.com/WordPress/gutenberg: [RNmobile] Fix problems with undo/redo on Android (#12417) Add registry param to withDispatch component (#11851) Autocompleters: Consider block category (#12287) Only init TinyMCE once per instance (#12386) RichText: convert HTML formatting whitespace to spaces (#12166) Notices: Remove "files" block in package.json (#12438) Edit Post: Avoid rendering AdminNotices compatibility component (#12444) Correct the docs manifest (#12411)
## Description Following on from #12411 and #11817 it was noticed that some pages were skipped, as they weren't included in the `toc.json` file previously. This PR includes several specific fixes which are all interconnected: 1. Adds the Internationalization page along with the Block Tutorial to the handbook hierarchy 1. An additional landing page for the Tutorials index was added 1. `Components` was added to the developers handbook alongside `Packages` and `Data Package Reference` pages. 1. In order to handle the above move, the duplicative declarations of `Packages`, `Data Package Reference` and `Components` were removed from `docs/tool/manifest.js` to prevent them adding as top-level-items. (Are these intended to be top-level-handbook-pages or deep within the developers handbook as the TOC seems to suggest?) I also took the opportunity to convert `generate.php` from the previous PR into a JS command that allows for `docs/root-manifest.json` to be removed entirely and dynamically generated from `docs/toc.json` so it only needs updating in a single location. That's the `getRootManifest()` and `generateRootManifestFromTOCItems()` functions which are rather messy, but work (I'm sure someone else could clean that up significantly). ## How has this been tested? The only testing done so far is the manual review of the final `docs/manifest.json`.
Description
As mentioned in #meta following #11817 the handbook import process failed to pick up the changed files, and resulted in a number of orphaned items.
The cause of this is several fold:
parent
field, where the importer only supports a singular slug (ie.developers
notdesigners-developers/developers
)slug
fields for root-level pagestoc.json
file which was used to generate theroot-manifest.json
didn't have thecontributors
orusers
handbook added to it, and as a resultroot-manifest.json
was never updated either (I couldn't find a tool which does this automatically, See 700e159 for the script I borrowed from Reorganise documentation #11817 and modified).Known Bugs
(Some of these are not bugs or should be individual issues/bugs/PRs, I'm noting it here though)
Users
handbook wasn't added to the TOC as nothing exists within it. The Gutenberg handbook landing page links to it though. Once content is added it'll need to be added totoc.json
androot-manifest.json
.Contributors
handbook index page has no text, and so is now blank.$slug-2
url, etc.How has this been tested?
It was used to import the docs onto https://wordpress.org/gutenberg/handbook/