Fix/issue 12033 url label #12959
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -53,38 +53,46 @@ function PostLink( { | |
| onToggle={ onTogglePanel } | ||
| > | ||
| { isEditable && ( | ||
| <div className="editor-post-link"> | ||
| <TextControl | ||
| label={ __( 'URL Slug:' ) } | ||
|
There was a problem hiding this comment. Though my search wasn't exhaustive, it seems as though most input field labels in the sidebar don't end with a colon. The only other one I could see is 'Parent Page:'. Might be good to drop the colon for sake of consistency. @jasmussen what do you think? There was a problem hiding this comment. That's an EXCELLENT catch & eye for detail. Yeah, if we can get that one final detail smoothed out let's ship it. Otherwise, this is also very lovely as is. There was a problem hiding this comment. @talldan @jasmussen removed the colon, nice catch! |
||
| value={ forceEmptyField ? '' : currentSlug } | ||
| onChange={ ( newValue ) => { | ||
| editPermalink( newValue ); | ||
| // When we delete the field the permalink gets | ||
| // reverted to the original value. | ||
| // The forceEmptyField logic allows the user to have | ||
| // the field temporarily empty while typing. | ||
| if ( ! newValue ) { | ||
| if ( ! forceEmptyField ) { | ||
| setState( { | ||
| forceEmptyField: true, | ||
| } ); | ||
| } | ||
| return; | ||
| } | ||
| if ( forceEmptyField ) { | ||
| setState( { | ||
| forceEmptyField: false, | ||
| } ); | ||
| } | ||
| } } | ||
| onBlur={ ( event ) => { | ||
| editPermalink( cleanForSlug( event.target.value ) ); | ||
| if ( forceEmptyField ) { | ||
| setState( { | ||
| forceEmptyField: false, | ||
| } ); | ||
| } | ||
| } } | ||
| /> | ||
| <p> | ||
| { __( 'The last part of the URL. ' ) } | ||
| <ExternalLink href="https://codex.wordpress.org/Posts_Add_New_Screen"> | ||
| { __( 'Read about permalinks' ) } | ||
| </ExternalLink> | ||
| </p> | ||
| </div> | ||
| ) } | ||
| <p className="edit-post-post-link__preview-label"> | ||
| { __( 'Preview' ) } | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the className
editor-post-linkdoesn't have any associated styles. It can probably be removed unless there's a good reason for it?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this div really necessary or should we just replace it with
<Fragment />