Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update of copy/paste support list #13300

Closed
wants to merge 0 commits into from
Closed

Update of copy/paste support list #13300

wants to merge 0 commits into from

Conversation

samy
Copy link

@samy samy commented Jan 12, 2019

Description

The copy/paste support list for Gutenberg has been updated since Gut can handle images copy/pasted from Word and Libre/Open Office

How has this been tested?

Tested manually on:

  • Word 2007/Windows/up-to-date WP 5.0
  • Open/Libre Office on OS X and Ubuntu

Types of changes

Only readme update

Checklist:

Only documentation update

@gziolo gziolo requested a review from ellatrix January 22, 2019 08:52
@gziolo gziolo added the [Type] Developer Documentation Documentation for developers label Jan 22, 2019
@gziolo gziolo requested a review from mcsf January 22, 2019 08:52
@gziolo gziolo added this to the Documentation & Handbook milestone Jan 22, 2019
@gziolo
Copy link
Member

gziolo commented Jan 22, 2019

@mcsf and @iseulde - I don't know what the current status is but it would be great if you could confirm that.

@samy thanks for opening this PR and investing your time testing all those tools 💯

@ellatrix
Copy link
Member

Could you show in a quick video that pasting images from MS Word works? Last time I checked we were given a file path which is useless. The only thing we could do is adding an image placeholder.

@samy
Copy link
Author

samy commented Jan 22, 2019

Here is an animated GIF of example (with PNG from WordPress website)

I pasted the PNG from Chrome to Word, and from Word to WordPress editor

github_gut_paste

It also works if I insert an image in Word by "Insert" feature.

In both cases, it creates a new attachement in WordPress media library

Copy link
Contributor

@mcsf mcsf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this, @samy! Since we're touching this table, I suggested a few additional things we can update.

packages/blocks/src/api/raw-handling/readme.md Outdated Show resolved Hide resolved
packages/blocks/src/api/raw-handling/readme.md Outdated Show resolved Hide resolved
packages/blocks/src/api/raw-handling/readme.md Outdated Show resolved Hide resolved
@ellatrix
Copy link
Member

@samy @mcsf Copy pasting a single image is not the same as copying the entire content. I don't think images are copied over when pasting the entire content? Perhaps a note that pasting single images works is good, but it still wouldn't work entirely.

@samy
Copy link
Author

samy commented Jan 29, 2019

@samy @mcsf Copy pasting a single image is not the same as copying the entire content. I don't think images are copied over when pasting the entire content? Perhaps a note that pasting single images works is good, but it still wouldn't work entirely.

I confirm pasting images + text doesn't work, it inserts image block + text blocks in Gut (it works only for single images)

@ellatrix
Copy link
Member

@samy I'm fine with updating the table, still saying images don't work, with a footnote that copying individual images works.

@mcsf
Copy link
Contributor

mcsf commented Feb 4, 2019

Hey @samy, are you up for applying the suggestions I attached when reviewing this PR? :)

@samy
Copy link
Author

samy commented Feb 8, 2019

Hey @samy, are you up for applying the suggestions I attached when reviewing this PR? :)

I resolved the conversation, so your changes have been included in my PR :) (if I understood how the PR/comments system works)

@ellatrix
Copy link
Member

ellatrix commented Feb 8, 2019

Why does it have ✘ for MS Office heading? Where is the ✘ for images? Why is the comment about it removed? It's not a to do, it's impossible to do anything with local file paths. [2] also seems to be missing.

@samy
Copy link
Author

samy commented Feb 10, 2019

Why does it have ✘ for MS Office heading? Where is the ✘ for images? Why is the comment about it removed? It's not a to do, it's impossible to do anything with local file paths. [2] also seems to be missing.

Copying images from MS Office worked in Gut when I started this PR

@ellatrix
Copy link
Member

In #13300 (comment) you confirmed that it doesn't work? It only works when you copy a single image.

@samy
Copy link
Author

samy commented Feb 11, 2019

In #13300 (comment) you confirmed that it doesn't work? It only works when you copy a single image.

I will update my PR, sorry

@youknowriad youknowriad removed this from the Documentation & Handbook milestone Mar 18, 2019
@ellatrix ellatrix closed this Apr 24, 2019
@ellatrix ellatrix mentioned this pull request Apr 24, 2019
5 tasks
@ellatrix
Copy link
Member

@samy Something seems to have gone wrong pushing my changes to this branch. Sorry about that. I created a new branch and PR #15149 and merged the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants