-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Beef up the padding on component panel titles. #1337
Conversation
This increases the size of the clickable target area for component panel titles by 30px in each direction, making them easier to click open & closed. Fixes #1335.
Alternative to negative margin is to create a separate wrapping component for the content itself, applying default padding there, and letting button / toggle render naturally at the bounds of the panel. Downside is more nodes on the page. Thoughts? |
I agree, negative margins are undesirable – it's hard for me to gauge to what degree for this project compared to others (WordPress itself, for example, is full of them.) My preference would be not to perpetuate the bad habit, but I didn't want to rough up Gutenberg too assertively out of the gate.
Good catch. I'll push that to my branch soon if no one else gets to it first. |
Once I removed the radius, it revealed there was a The result is a The missing right-outline is also undesirable, but fixing that is its own rabbit hole. |
Did you try to rebase here? I think the 1px margin might have been fixed. |
Not sure if this one is browser-specific, but FWIW I was not able to reproduce this margin when removing the margin locally. It feels a little crowded when focus highlight is active on an expanded panel, but I don't find it particularly problematic. |
Thanks for this PR! Feels sooo much better now. |
This increases the size of the clickable target area for component panel titles by 30px in each direction, making them easier to click open & closed.
Fixes #1335.