RSS Block: support className attribute #13561
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Soean
added
the
[Block] RSS
gziolo
added
the
Good First Review
codebykat
suggested changes
Mar 9, 2019
There was a problem hiding this comment.
I had to rebase this because I was getting "The editor has encountered an unexpected error" for whatever reason. But after a rebase and applying the suggested change by @noisysocks it is working great!
Testing steps I followed:
- Add an RSS block to a post
- Add a URL and click "Use URL"
- Add an Additional CSS Class under Advanced
- Update the post and verify that the class name was added, along with wp-block-rss
- Delete the class name, update the post and verify that the class name is set to only wp-block-rss (with no empty spaces in the DOM).
Co-Authored-By: Soean <soerenwrede@gmail.com>
Soean
requested review from
notnownikki,
talldan and
youknowriad
as code owners
|
merged in #14533 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the custom
classNameattribute to the RSS block.Also orders the attributes in a alphabetical order.