Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow: Add repository CODEOWNERS file #13604

Merged
merged 7 commits into from
Feb 4, 2019
Merged
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
80 changes: 80 additions & 0 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
@@ -0,0 +1,80 @@
# Fallback Coverage
* @WordPress/gutenberg-core

# Data
/packages/api-fetch @WordPress/gutenberg-core @nerrad
/packages/core-data @WordPress/gutenberg-core @nerrad
/packages/data @WordPress/gutenberg-core @nerrad
/packages/redux-routine @WordPress/gutenberg-core @nerrad

# Blocks
/packages/block-library @WordPress/gutenberg-core @Soean @ajitbohra

# Editor
/packages/annotations @WordPress/gutenberg-core
/packages/autop @WordPress/gutenberg-core
/packages/block-serialization-spec-parser @WordPress/gutenberg-core
/packages/block-serialization-default-parser @WordPress/gutenberg-core
/packages/blocks @WordPress/gutenberg-core
/packages/edit-post @WordPress/gutenberg-core
/packages/editor @WordPress/gutenberg-core @nosolosw
/packages/list-reusable-blocks @WordPress/gutenberg-core
/packages/rich-text @WordPress/gutenberg-core
/packages/shortcode @WordPress/gutenberg-core

# Tooling
/bin @WordPress/gutenberg-core @ntwb @nerrad @ajitbohra
/packages/babel-plugin-import-jsx-pragma @WordPress/gutenberg-core @ntwb @nerrad @ajitbohra
/packages/babel-plugin-makepot @WordPress/gutenberg-core @ntwb @nerrad @ajitbohra
/packages/babel-preset-default @WordPress/gutenberg-core @ntwb @nerrad @ajitbohra
/packages/browserslist-config @WordPress/gutenberg-core @ntwb @nerrad @ajitbohra
/packages/custom-templated-path-webpack-plugin @WordPress/gutenberg-core @ntwb @nerrad @ajitbohra
/packages/e2e-test-utils @WordPress/gutenberg-core @ntwb @nerrad @ajitbohra
/packages/e2e-tests @WordPress/gutenberg-core @ntwb @nerrad @ajitbohra
/packages/eslint-plugin @WordPress/gutenberg-core @ntwb @nerrad @ajitbohra
/packages/jest-console @WordPress/gutenberg-core @ntwb @nerrad @ajitbohra
/packages/jest-preset-default @WordPress/gutenberg-core @ntwb @nerrad @ajitbohra
/packages/jest-puppeteer-axe @WordPress/gutenberg-core @ntwb @nerrad @ajitbohra
/packages/library-export-default-webpack-plugin @WordPress/gutenberg-core @ntwb @nerrad @ajitbohra
/packages/npm-package-json-lint-config @WordPress/gutenberg-core @ntwb @nerrad @ajitbohra
/packages/postcss-themes @WordPress/gutenberg-core @ntwb @nerrad @ajitbohra
/packages/scripts @WordPress/gutenberg-core @ntwb @nerrad @ajitbohra

# UI Components
/packages/components @WordPress/gutenberg-core @chrisvanpatten @ajitbohra @jaymanpandya @nosolosw
/packages/compose @WordPress/gutenberg-core @chrisvanpatten @ajitbohra @jaymanpandya
/packages/element @WordPress/gutenberg-core @chrisvanpatten @ajitbohra @jaymanpandya
/packages/notices @WordPress/gutenberg-core @chrisvanpatten @ajitbohra @jaymanpandya
/packages/nux @WordPress/gutenberg-core @chrisvanpatten @ajitbohra @jaymanpandya
/packages/viewport @WordPress/gutenberg-core @chrisvanpatten @ajitbohra @jaymanpandya

# Utilities
/packages/a11y @WordPress/gutenberg-core
/packages/blob @WordPress/gutenberg-core
/packages/date @WordPress/gutenberg-core
/packages/deprecated @WordPress/gutenberg-core
/packages/dom @WordPress/gutenberg-core
/packages/dom-ready @WordPress/gutenberg-core
/packages/escape-html @WordPress/gutenberg-core
/packages/html-entities @WordPress/gutenberg-core
/packages/i18n @WordPress/gutenberg-core
/packages/is-shallow-equal @WordPress/gutenberg-core
/packages/keycodes @WordPress/gutenberg-core
/packages/priority-queue @WordPress/gutenberg-core
/packages/token-list @WordPress/gutenberg-core
/packages/url @WordPress/gutenberg-core
/packages/wordcount @WordPress/gutenberg-core

# Extensibility
/packages/hooks @WordPress/gutenberg-core
/packages/plugins @WordPress/gutenberg-core

# Rich Text
/packages/format-library @WordPress/gutenberg-core
/packages/rich-text @WordPress/gutenberg-core

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about CSS group and *.scss pattern match?

# PHP
/lib @WordPress/gutenberg-core
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also add *.php in the PHP section.


# Documentation
/docs @WordPress/gutenberg-core @chrisvanpatten @mkaz @ajitbohra @nosolosw
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also add *.md in the Documentation section.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also add *.md in the Documentation section.

This would trigger any CHANGELOG.md edits, which any pull request should include.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, how about */README.md then?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, how about */README.md then?

I think that could work, sure 👍

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, how about */README.md then?

I think that could work, sure 👍

On second thought, I'm wondering if it might be better to leave out initially, as I worry it could become quite noisy. Like CHANGELOG, I think it could be that a large number of pull requests would include README changes to document their impact to public-facing APIs, in a way which perhaps loses its effectiveness to notifying the "most correct" parties.

Put another way, we can have much more confidence that a change to a file within /docs is part of a pull request oriented toward documentation than one which includes a change to a README file.