Add calendar block v1 #13772

jorgefilipecosta · 2019-02-08T12:31:52Z

Description

Closes #1462.

The first version of the calendar block.
The design tries to follow the mockup proposed but is not exactly equal as getting the desired result would need a change of markup while this version is a pure CSS solution.

If we decide to change the markup to get to the desired design I think we will not be able to use get_calendar as it is right now and the best option seems to be using a custom version of get_calendar creating a new function in core that abstracts get_calendar logic and allows both get_calendar and the version we use in this block to be created in a simple way.
We can also use current filters on get_calenger plus some regex replaces to get the markup in the desired state, but that is very hacky and probably not a long term solution.

How has this been tested?

Verify the calendar block works as expected in the editor and in the front end.
Verify that when we change the publish date month and/or year the calendar updates.

Screenshots

gziolo · 2019-02-08T13:17:53Z

packages/block-library/src/calendar/edit.js

+	getServerSideAttributes( attributes, date ) {
+		return {
+			...attributes,
+			...this.getYearMonth( date ),


Why not set it on the server using WP functions?

When the user changes the publish date, even if the post is not yet saved we want the user to see the calendar of that publish date so we need a way to pass that information to the server, that exactly what we are doing here.
The attributes month and year are never saved, they are just transient attributes used by the server side render mechanism.

I still think it isn't a good approach. Let me explain on the post from my personal website:
https://gziolo.pl/2017/11/07/starter-kit-and-reusable-scripts/
If I visit it as of today you will see that the calendar in the sidebar renders the same month as when this post was published:

it behaves differently for the pages as it simply renders the current month:

There are also archive pages which follow the URL path:

This should also be the case when I want to edit my post in Gutenberg. That's why I suggested that we build logic on PHP side which tries the following:

if it is a post type get the publish date from the post metadata

if it is a page or custom CPT get the current month

@melchoyce does it make sense?

Thinking a bit more about it. I'm coming to the conclusion that it might be nice to explore the following UI improvement around month and date. What if we allow the author to pick what calendar would display, some options to consider:

inherit the post's date (this is what we have at the moment)

use the current date

let the author pick any date

/cc @mapk and @youknowriad for feedback

melchoyce · 2019-02-08T18:13:44Z

Seeing a gap here where the header area doesn't totally extend the width of the block:

I can't click this arrow, and with it's position + no label, I don't think it's clear what it does:

It's more obvious in the date picker component because of proximity:

Where are the styles coming from? Are they the default calendar widget styles?

noisysocks

This is looking pretty cool! 😎

packages/block-library/src/calendar/index.php

packages/block-library/src/calendar/style.scss

packages/block-library/src/calendar/index.js

mapk · 2019-02-12T01:32:55Z

Can't wait to get this in!

I think Mel brought up an interesting correlation above between this block and the DatePicker component. Is it possible to get the Calendar to match the styles of the DatePicker?

Also noticed I can't interact with the arrow in the calendar to switch months, and when I tried to interact with it on the frontend, it took me to a different post completely.

jorgefilipecosta · 2019-02-12T15:40:07Z

Hi @melchoyce, @noisysocks, and @mapk thank you for the reviews most of the points raized were addressed.

Where are the styles coming from? Are they the default calendar widget styles?

The styles are specific to this block they were created without changing the original markup using this image as referential:

Unfortunately, without changing the markup, I don't think it is possible to get the arrows in the right position.

I think this version is possible to achieve with the current markup:

As a reference the default calendar styles look like this:

I think Mel brought up an interesting correlation above between this block and the DatePicker component. Is it possible to get the Calendar to match the styles of the DatePicker?

Yes, it is possible to get the same look on the editor. In that case, probably it would be worth it to use the DatePicker component directly and create a JS UI instead of relying on ServerSide render, which is probably going to be useful anyway if we want to follow more advanced use cases.

I have some questions about the way calendar block should work on the frontend and what differences should exist when compared with the calendar widget.

Currently, the calendar widget renders the calendar of the month the current post was published, if the widget is an archives page it renders the calendar of that month, and if it is a neutral non-date specific page (homepage, taxonomy, author) it renders the calendar of the current month.
There is no interactivity on the widget frontend it just links to the archives of the previous/next month and the days.

The current calendar block implementation tries to follow the same approach.

The blocks show the calendar of the month associated with the post publish date. When we update the month/year of publish date, we can see on the editor the block also gets updated.

If we allow the user to scroll between months what is the practical effect of the scroll? Should we start showing the calendar of the month chosen by the user instead of relying on the publish date?

On the frontend of the website should the calendar also look like the DatePicker component or should different styles be used?

Regarding interactivity should the frontend also be interactive?
If yes we will face a new challenge, have core widgets that have JavaScript on the frontend.
Probably even if the styles are the same as DatePicker we will not be able to use DatePicker directly because that would make us need to include React on the frontend of the websites with the react-dates library which are huge.

youknowriad · 2019-02-12T16:00:52Z

If yes we will face a new challenge, have core widgets that have JavaScript on the frontend.

How does the widget work, we should just do the same thing for the moment.

jorgefilipecosta · 2019-02-12T16:16:59Z

How does the widget work, we should just do the same thing for the moment.

That's the current state we have exactly the same thing as the calendar widget on the frontend just with some styles changes (that can be reverted).

melchoyce · 2019-02-12T17:52:05Z

Ah, yes. The styles came from my mockups. 🤦‍♂️

I think this version is possible to achieve with the current markup

If we can't change the markup, let's do either that, or the default calendar styles — they're actually not that bad. (@mapk, what do you think?)

Since you can't interact with the calendar months (I forgot about that part), can we do cursor: not-allowed on hover, so it's clear you can't select the links? (Is there a mobile equivalent?)

While the default calendar behavior doesn't make much sense, I agree we should probably just stick with it for this v1.

jorgefilipecosta · 2019-02-12T21:40:39Z

Hi,

I iterated on the styles to get them closer to this version:

Current design:

This version of the mockup should be possible without any markup change (which if possible it would be better to avoid it for now), so we can continue to iterate on this version.

I can also add some classes used by the calendar widget, and we can go for the calendar widget styles.

Since you can't interact with the calendar months (I forgot about that part), can we do cursor: not-allowed on hover, so it's clear you can't select the links? (Is there a mobile equivalent?)

We are using the Disable component which ensures the user is not able to interact with the calendar (e.g., follow the links) similar to what we do in other blocks e.g.: RSS, latest comments, etc... Should the not-allowed cursor be added at the component level, so all the blocks in a similar situation benefit from it?

mapk · 2019-02-12T21:52:18Z

All points being made are good. Let's avoid any markup changes and keep the current widget interaction model. I definitely don't want this getting out of hand. But as Mel mentioned above, let's avoid any confusion in the arrows.

youknowriad · 2019-02-14T10:00:14Z

Here we go 🎉

gziolo · 2019-02-14T10:05:31Z

I suspect that this is just one of the inherent downsides of using ServerSideRender, though 🙂

Yes, this is a very unfortunate side effect of using ServerSideRender which is a quick way to bring many of the existing widgets into the block editor. I suggested we go this route to have this block available with as little effort as possible for start. I know that @jorgefilipecosta has lots of great ideas on how to further iterate and this is going to be only easier having this PR merged into master. I could find a few another benefits of having early version available in the next Gutenberg release :)

Great work @jorgefilipecosta!

jorgefilipecosta · 2019-02-14T10:08:33Z

Thank you for the reviews! If someone finds any additional improvement feel free to comment and I will iterate on follow up PR's.

gziolo

I left some more thoughts about the way we select year and month to consider for the future. I didn't see them as the blocker for the initial version of the PR. It's more my wishful thinking on how to mirror frontend and the editor :)

gziolo · 2019-02-14T10:21:55Z

packages/block-library/src/calendar/index.php

+ * @return string Returns the block content.
+ */
+function render_block_core_calendar( $attributes ) {
+	global $monthnum, $year, $post;


Interesting, $post is never used. Any reason why phpcs doesn't scream?

gziolo · 2019-02-14T10:34:39Z

packages/block-library/src/calendar/edit.js

+	getServerSideAttributes( attributes, date ) {
+		return {
+			...attributes,
+			...this.getYearMonth( date ),


I still think it isn't a good approach. Let me explain on the post from my personal website:
https://gziolo.pl/2017/11/07/starter-kit-and-reusable-scripts/
If I visit it as of today you will see that the calendar in the sidebar renders the same month as when this post was published:

it behaves differently for the pages as it simply renders the current month:

There are also archive pages which follow the URL path:

This should also be the case when I want to edit my post in Gutenberg. That's why I suggested that we build logic on PHP side which tries the following:

if it is a post type get the publish date from the post metadata

if it is a page or custom CPT get the current month

@melchoyce does it make sense?

jorgefilipecosta · 2019-02-14T11:45:19Z

Hi @gziolo a follow-up PR that addressed the problems raised was opened at #13873. Thank you for your tests 👍

The first version of the calendar block. The design tries to follow the mockup proposed.

jorgefilipecosta requested review from aduth, ajitbohra, gziolo, noisysocks, notnownikki, Soean, talldan and youknowriad as code owners February 8, 2019 12:31

youknowriad added Needs Design Feedback Needs general design feedback. Needs Accessibility Feedback Need input from accessibility [Feature] Blocks Overall functionality of blocks [Feature] Widgets Screen The block-based screen that replaced widgets.php. labels Feb 8, 2019

youknowriad added this to the 5.1 (Gutenberg) milestone Feb 8, 2019

gziolo reviewed Feb 8, 2019

View reviewed changes

gziolo requested review from melchoyce and mapk February 8, 2019 13:18

jorgefilipecosta force-pushed the add/calendar-block-ssr branch 2 times, most recently from 761c864 to e25812d Compare February 8, 2019 15:19

noisysocks reviewed Feb 11, 2019

View reviewed changes

jorgefilipecosta force-pushed the add/calendar-block-ssr branch from d80dfa2 to 0c6309f Compare February 12, 2019 15:08

jorgefilipecosta force-pushed the add/calendar-block-ssr branch from 0c6309f to 4a98d8a Compare February 12, 2019 15:41

jorgefilipecosta force-pushed the add/calendar-block-ssr branch from 9b88fbb to 98ee7fb Compare February 12, 2019 21:33

jorgefilipecosta deleted the add/calendar-block-ssr branch February 14, 2019 09:57

gziolo reviewed Feb 14, 2019

View reviewed changes

jorgefilipecosta mentioned this pull request Feb 14, 2019

Fix: Calendar block: Always show current month for non post types on the editor #13873

Merged

This was referenced Feb 18, 2019

Bump plugin version to 5.1.0-rc.1 #13908

Merged

Bump plugin version to 5.1.0 #13960

Merged

youknowriad pushed a commit that referenced this pull request Mar 6, 2019

Add calendar block v1 (#13772)

6ea4468

The first version of the calendar block. The design tries to follow the mockup proposed.

youknowriad pushed a commit that referenced this pull request Mar 6, 2019

Add calendar block v1 (#13772)

9e31eb5

The first version of the calendar block. The design tries to follow the mockup proposed.

gziolo assigned jorgefilipecosta Mar 22, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add calendar block v1 #13772

Add calendar block v1 #13772

jorgefilipecosta commented Feb 8, 2019 •

edited by gziolo

Loading

gziolo Feb 8, 2019

jorgefilipecosta Feb 8, 2019

gziolo Feb 14, 2019

gziolo Feb 14, 2019

melchoyce commented Feb 8, 2019

noisysocks left a comment

mapk commented Feb 12, 2019

jorgefilipecosta commented Feb 12, 2019

youknowriad commented Feb 12, 2019

jorgefilipecosta commented Feb 12, 2019 •

edited

Loading

melchoyce commented Feb 12, 2019

jorgefilipecosta commented Feb 12, 2019 •

edited

Loading

mapk commented Feb 12, 2019

youknowriad commented Feb 14, 2019

gziolo commented Feb 14, 2019

jorgefilipecosta commented Feb 14, 2019

gziolo left a comment

gziolo Feb 14, 2019

gziolo Feb 14, 2019

jorgefilipecosta commented Feb 14, 2019

Add calendar block v1 #13772

Add calendar block v1 #13772

Conversation

jorgefilipecosta commented Feb 8, 2019 • edited by gziolo Loading

Description

How has this been tested?

Screenshots

gziolo Feb 8, 2019

Choose a reason for hiding this comment

jorgefilipecosta Feb 8, 2019

Choose a reason for hiding this comment

gziolo Feb 14, 2019

Choose a reason for hiding this comment

gziolo Feb 14, 2019

Choose a reason for hiding this comment

melchoyce commented Feb 8, 2019

noisysocks left a comment

Choose a reason for hiding this comment

mapk commented Feb 12, 2019

jorgefilipecosta commented Feb 12, 2019

youknowriad commented Feb 12, 2019

jorgefilipecosta commented Feb 12, 2019 • edited Loading

melchoyce commented Feb 12, 2019

jorgefilipecosta commented Feb 12, 2019 • edited Loading

mapk commented Feb 12, 2019

youknowriad commented Feb 14, 2019

gziolo commented Feb 14, 2019

jorgefilipecosta commented Feb 14, 2019

gziolo left a comment

Choose a reason for hiding this comment

gziolo Feb 14, 2019

Choose a reason for hiding this comment

gziolo Feb 14, 2019

Choose a reason for hiding this comment

jorgefilipecosta commented Feb 14, 2019

jorgefilipecosta commented Feb 8, 2019 •

edited by gziolo

Loading

jorgefilipecosta commented Feb 12, 2019 •

edited

Loading

jorgefilipecosta commented Feb 12, 2019 •

edited

Loading