Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gallery: translate string, not results of sprintf #13830

Merged
merged 1 commit into from
Feb 13, 2019
Merged

Gallery: translate string, not results of sprintf #13830

merged 1 commit into from
Feb 13, 2019

Conversation

simison
Copy link
Member

@simison simison commented Feb 12, 2019

Description

Translation function was previously wrapping results of sprintf, instead of the string passed to sprinf.

How has this been tested?

  • Add Gallery block in the editor
  • Add some images
  • Observe aria label look correct (you should see aria-label="image 1 of 2 in gallery" etc)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@youknowriad youknowriad added the Good First Review A PR that's suitable for someone looking to contribute for the first time by reviewing code label Feb 12, 2019
@gziolo gziolo added this to the 5.1 (Gutenberg) milestone Feb 12, 2019
@gziolo gziolo added the Internationalization (i18n) Issues or PRs related to internationalization efforts label Feb 12, 2019
@gziolo gziolo merged commit 8f9738d into WordPress:master Feb 13, 2019
@gziolo
Copy link
Member

gziolo commented Feb 13, 2019

Nice catch, thanks!

@simison simison deleted the patch-2 branch February 13, 2019 06:25
This was referenced Feb 18, 2019
Merged
Merged
youknowriad pushed a commit that referenced this pull request Mar 6, 2019
@simison @youknowriad
Gallery: translate string, not results of sprintf (#13830)
47a7f03
youknowriad pushed a commit that referenced this pull request Mar 6, 2019
@simison @youknowriad
Gallery: translate string, not results of sprintf (#13830)
c98f664
This was referenced Apr 30, 2020
Closed
Closed
Merged
Merged
Merged
Closed
Closed
Closed
Closed
This was referenced May 1, 2020
Merged
Closed
Merged
Closed
Merged
Closed
Closed
Closed
@yassine4999 yassine4999 mentioned this pull request May 13, 2024
Open
@jay-Anonymous jay-Anonymous mentioned this pull request May 14, 2024
Open
@npneeraj npneeraj mentioned this pull request May 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocean90 ocean90 ocean90 approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@gziolo gziolo Awaiting requested review from gziolo

@jorgefilipecosta jorgefilipecosta Awaiting requested review from jorgefilipecosta

@noisysocks noisysocks Awaiting requested review from noisysocks

@notnownikki notnownikki Awaiting requested review from notnownikki

@Soean Soean Awaiting requested review from Soean

@talldan talldan Awaiting requested review from talldan

@youknowriad youknowriad Awaiting requested review from youknowriad

Assignees
No one assigned
Labels
Good First Review A PR that's suitable for someone looking to contribute for the first time by reviewing code Internationalization (i18n) Issues or PRs related to internationalization efforts
Projects
None yet
Milestone
5.1 (Gutenberg)
Development

Successfully merging this pull request may close these issues.
4 participants
@simison @gziolo @ocean90 @youknowriad