-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: missing className on latest comments block #13834
Fix: missing className on latest comments block #13834
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
It was challenging to test because when the Gutenberg plugin is installed with WordPress 5.0, we don't require packages/block-library/src/latest-comments/index.php
and so this change doesn't appear. I manually applied the diff to the Core PHP files. Not sure how we can make this easier.
Thank you for review @noisysocks!
I'm sorry for the trouble caused I should have referred this need in the PR description. |
No apology necessary, Jorge! 🙂 Thanks for fixing this. |
Description
Fixes: #13773
The custom className was not being applied on the latest comments block.
How has this been tested?
I added a latest comments block; I checked using the browser inspector that on the editor by default no class name is applied and no unrequired empty spaces exist on the class field. I published the post and repeated the same checks on the frontend.
I added a custom className to the block and verified it was applied on the editor and the frontend.
I removed the className and verified the className was removed, and no unrequired empty spaces were added.