-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation: update install commands and babel config #13853
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not quite sure why --save-exact
solves this issue given that both webpack and @wordpress/scripts
follow semantic versioning. However if that helps, I'm fine with the changes proposed.
@gziolo |
It might be something about the dependencies included by |
The root problem seems related to |
Do you know what is using Babel 6 specific packages causing babel-loader@7 to be pulled in? |
@gziolo not sure I follow. Here's what I know:
I chose to go with the first option because that's what Gutenberg uses. |
Why would you want to install it in the first place?
Yes, this is highly expected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's update for the time being and wait until we can address #13712 to make it perfect.
This PR fixes some problems I ran into when following the current guide. It also promotes the use of
--save-exact
as a good hygiene practice.