Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix small regression introduced in the region navigation styles #13897

Merged
merged 1 commit into from
Feb 15, 2019
Merged

Fix small regression introduced in the region navigation styles #13897

merged 1 commit into from
Feb 15, 2019

Conversation

youknowriad
Copy link
Contributor

Related #8554 (comment)

Try navigation the aria regions in both full screen and normal mode.

@youknowriad youknowriad added [Type] Bug An existing feature does not function as intended [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). labels Feb 15, 2019
@youknowriad youknowriad added this to the 5.1 (Gutenberg) milestone Feb 15, 2019
@youknowriad youknowriad self-assigned this Feb 15, 2019
@jorgefilipecosta jorgefilipecosta self-requested a review February 15, 2019 15:56
jorgefilipecosta
jorgefilipecosta approved these changes Feb 15, 2019
View reviewed changes
Copy link
Member

@jorgefilipecosta jorgefilipecosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 The landmark region navigation seems to work correctly in full-screen mode after these changes.
It also fixes a problem in normal mode where if we continuously navigate around landmarks the sidebar disappears and reappears after:
feb-15-2019 16-02-15

@youknowriad youknowriad merged commit 3e56d7c into master Feb 15, 2019
@youknowriad youknowriad deleted the fix/region-navigation-styles branch February 15, 2019 16:16
youknowriad added a commit that referenced this pull request Mar 6, 2019
@youknowriad
Fix small regression introduced in the region navigation styles (#13897)
fa20b50
youknowriad added a commit that referenced this pull request Mar 6, 2019
@youknowriad
Fix small regression introduced in the region navigation styles (#13897)
b732c26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgefilipecosta jorgefilipecosta jorgefilipecosta approved these changes

@afercia afercia Awaiting requested review from afercia

@jasmussen jasmussen Awaiting requested review from jasmussen

@gziolo gziolo Awaiting requested review from gziolo

Assignees

@youknowriad youknowriad

Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
5.1 (Gutenberg)
Development

Successfully merging this pull request may close these issues.
2 participants
@youknowriad @jorgefilipecosta