Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't do anything in RichTextInputEvent on native mobile #13929

Merged
merged 1 commit into from
Feb 18, 2019
Merged

Don't do anything in RichTextInputEvent on native mobile #13929

merged 1 commit into from
Feb 18, 2019

Conversation

hypest
Copy link
Contributor

@hypest hypest commented Feb 18, 2019

Description

Recent work (#13833) on the RichText implementation has introduced the RichTextInputEvent component but, that doesn't play well on native mobile since there is no real DOM available. This PR just "grounds" the component to just have it do nothing in the native mobile case.

How has this been tested?

Use the gutenberg-mobile side PR: wordpress-mobile/gutenberg-mobile#612

Types of changes

Introduce a native mobile implementation of the RichTextInputEvent component that does nothing.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@hypest hypest added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Feb 18, 2019
@SergioEstevao SergioEstevao self-requested a review February 18, 2019 16:53
SergioEstevao
SergioEstevao approved these changes Feb 18, 2019
View reviewed changes
Copy link
Contributor

@SergioEstevao SergioEstevao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is working fine on the mobile apps, but for some reason, we have a failed unit test.

@SergioEstevao SergioEstevao merged commit c17239f into master Feb 18, 2019
@marecar3 marecar3 self-requested a review February 18, 2019 19:39
@marecar3
Copy link
Contributor

LGTM on Android device!

@marecar3 marecar3 deleted the rnmobile/ground-richtextinputevent branch February 18, 2019 20:32
@youknowriad youknowriad added this to the 5.2 (Gutenberg) milestone Mar 4, 2019
youknowriad pushed a commit that referenced this pull request Mar 6, 2019
@hypest @youknowriad
Don't do anything in RichTextInputEvent on native mobile (#13929)
7f09d9c
youknowriad pushed a commit that referenced this pull request Mar 6, 2019
@hypest @youknowriad
Don't do anything in RichTextInputEvent on native mobile (#13929)
2867264
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergioEstevao SergioEstevao SergioEstevao approved these changes

@marecar3 marecar3 Awaiting requested review from marecar3

Assignees
No one assigned
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
None yet
Milestone
5.2 (Gutenberg)
Development

Successfully merging this pull request may close these issues.
4 participants
@hypest @marecar3 @SergioEstevao @youknowriad