Fix column moved in itself error #13941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Naerriel
requested review from
gziolo,
noisysocks,
talldan and
youknowriad
as code owners
…fix/column-moved-in-itself
talldan
reviewed
Feb 19, 2019
gziolo
added
[Type] Bug
Co-Authored-By: Naerriel <naerriel@gmail.com>
talldan
approved these changes
Feb 19, 2019
There was a problem hiding this comment.
Gave this a further test, it works well. I tried a few different blocks with inner blocks including third-party ones from the coblocks and stackable plugins. All were prevented from being dragged inside themselves 😄
Also confirmed that normal dragging and dropping still works.
|
Good job @Naerriel, keep up great work 🥇 |
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
* Fix column moved in itself error * Update packages/editor/src/components/block-drop-zone/index.js Co-Authored-By: Naerriel <naerriel@gmail.com>
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
* Fix column moved in itself error * Update packages/editor/src/components/block-drop-zone/index.js Co-Authored-By: Naerriel <naerriel@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #13701
The bug is that empty column has no children and
dstClientIdwasundefined, therefore it could not be recognized as moved block's child.In solution I assumed that each 2 blocks that can be moved in each other are always separated by a
core/columnblock.If that assumption is incorrect or unsustainable I can leave:
and just add:
along the previous version.
How has this been tested?
Screenshots
Types of changes
Bug fix
Checklist: