Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update/ui controls focus style #1414

Merged
merged 3 commits into from
Jul 24, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion editor/assets/stylesheets/_z-index.scss
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
// value is designed to work with).

$z-layers: (
'.editor-mode-switcher .dashicon': -1,
'.editor-block-switcher__arrow': 1,
'.editor-visual-editor__block:before': -1,
'.editor-visual-editor__block {core/image aligned left or right}': 10,
Expand Down
2 changes: 2 additions & 0 deletions editor/header/mode-switcher/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,12 @@ function ModeSwitcher( { mode, onSwitch } ) {
/* eslint-disable jsx-a11y/no-onchange */
return (
<div className="editor-mode-switcher">
<label htmlFor="editor-mode-switcher__input" className="screen-reader-text">{ __( 'Change editor mode' ) }</label>
<select
value={ mode }
onChange={ ( event ) => onSwitch( event.target.value ) }
className="editor-mode-switcher__input"
id="editor-mode-switcher__input"
>
{ MODES.map( ( { value, label } ) =>
<option key={ value } value={ value }>
Expand Down
32 changes: 18 additions & 14 deletions editor/header/mode-switcher/style.scss
Original file line number Diff line number Diff line change
Expand Up @@ -14,35 +14,39 @@
background: transparent;
line-height: 1;
border: 0;
border-radius: 0;
-webkit-appearance: none;
outline: none;
border-radius: 4px;
appearance: none;
cursor: pointer;
box-shadow: none;
padding-right: 0;
padding: 10px 8px;
font-size: $default-font-size;
line-height: 16px;
height: auto;

/* IE10+ */
&::-ms-expand {
display: none;
}

@include break-small {
padding-right: 24px;
padding-right: 26px;
}

&:focus {
outline: none;
box-shadow: 0 0 0 1px $blue-medium-400, 0 0 2px 1px $blue-medium-400;
}
}

.dashicon {
position: relative;
z-index: z-index( '.editor-mode-switcher .dashicon' );
margin-left: -24px;
margin-top: -1px;

left: -26px;
margin-right: -20px;
pointer-events: none;
display: none;

@include break-small {
display: block;
}
}

&:hover,
select:hover {
color: $dark-gray-900;
}
}
1 change: 0 additions & 1 deletion editor/header/saved-state/style.scss
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
color: $blue-wordpress;

&:focus {
box-shadow: none;
outline: none;
}

Expand Down
7 changes: 7 additions & 0 deletions editor/header/tools/style.scss
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,13 @@
@include break-medium() {
margin-right: 4px;
}

@include break-mobile {
&.dashicons-undo,
&.dashicons-redo {
margin-right: 0;
}
}
}

.editor-tools__tabs {
Expand Down
2 changes: 1 addition & 1 deletion editor/sidebar/post-trash/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ function PostTrash( { postId, postType, ...props } ) {
const onClick = () => props.trashPost( postId, postType );

return (
<Button className="editor-post-trash" onClick={ onClick }>
<Button className="editor-post-trash button-link button-link-delete" onClick={ onClick }>
{ __( 'Move to trash' ) }
<Dashicon icon="trash" />
</Button>
Expand Down
18 changes: 7 additions & 11 deletions editor/sidebar/post-trash/style.scss
Original file line number Diff line number Diff line change
@@ -1,14 +1,10 @@
.editor-post-trash {
display: flex;
justify-content: flex-end;
align-items: center;
cursor: pointer;
color: inherit;
flex-grow: 1;
color: $alert-red;

margin-left: auto !important;
text-decoration: underline;

.dashicon {
margin-right: -10px;
margin-left: 10px;
display: inline-block;
vertical-align: middle;
margin: -3px -4px 0 10px;
}
}
}