Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make selected post-title unselect when another block selected #1426

Closed
wants to merge 4 commits into from
Closed

Make selected post-title unselect when another block selected #1426

wants to merge 4 commits into from

Conversation

kamataryo
Copy link
Contributor

Fix for #1390

@kamataryo kamataryo changed the title Add unselect onBlur Patch for title block selection bug Jun 25, 2017
@kamataryo
Copy link
Contributor Author

Previous:
pre

This patch:
post

@kamataryo kamataryo changed the title Patch for title block selection bug Set onBlur callback for title block selection bug Jun 25, 2017
@youknowriad
Copy link
Contributor

This is more complex than it seems, try saving you'll notice the permalink modal, and the title should remain selected (with borders) when we hit the "copy" button from the permalink modal.

KamataRyo added 3 commits June 27, 2017 14:16
Unselect only when the blocks selected.
For example, make the post-title keep selected with permalink modal
@kamataryo kamataryo changed the title Set onBlur callback for title block selection bug Make selected post-title unselect when another block selected Jun 27, 2017
@kamataryo
Copy link
Contributor Author

@youknowriad Thanks for the comment. I fixed this PR and make the post-title check whether blocks selected or not and not attach is-selected class if so.

@mtias
Copy link
Member

mtias commented Jun 28, 2017

So here's a thought. What if we convert this to be a real block again, with the restrictions that:

  • it's already inserted by default.
  • you cannot move it.
  • it doesn't show in the inserter.
  • (bonus) you can hide it in the inspector to get an "aside".

This should give us the interactions for free, as well as pave the way for cusotmization where you will be able to do more stuff with these non-content pieces (meta data, title, date, categories, etc).

@gziolo
Copy link
Member

gziolo commented Jan 27, 2018

#1390 was fixed in other PR. I'm closing this one. Thanks for spending your time on this PR :)

@gziolo gziolo closed this Jan 27, 2018
youknowriad pushed a commit that referenced this pull request Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants