-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use <s> for strikethrough, not <del> #14389
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The semantics strike me as being correct justification, yes 👍
Is there a way to provide a "deprecated" version :P or away to support previous content :) (to be able to untoggle them). I don't consider this critical but thought I'd ask. |
@youknowriad No, there isn't at the moment. A button cannot be assigned to two formats. I think it's fine since strikethrough is a much lesser used format, and you can still remove it in HTML view. Perhaps we should consider adding a "clear formatting" button at some point which could clear all known and unknown formatting. |
Yes, It's fine for me but we can think about it if we notice this pattern of changing formats more. Let's move forward. |
Yeah, I agree if we'd want to change bold or italic. Speaking of which, let me check who uses |
Ugh, I now just realise that we should update paste. |
* Use <s> for strikethrough, not <del> * Update e2e test
* Use <s> for strikethrough, not <del> * Update e2e test
Description
The s element falls under text-level semantics, just like bold and italic.
The ins and del elements represent edits to the document.
The
ins
anddel
element are meant to be used together. They also share the same attribute spec (cite
anddatetime
).What about other editors?
Thoughts?
How has this been tested?
Screenshots
Types of changes
Checklist: