Upgrade React to 16.8.4: Welcome React Hooks #14400
Conversation
youknowriad
requested review from
aduth,
ajitbohra,
gziolo,
jorgefilipecosta,
noisysocks and
talldan
as code owners
youknowriad
added
the
Framework
youknowriad
changed the title
youknowriad
force-pushed
the
update/react-16.8-try-2
branch
from
05617b8 to
dd24509
Compare
youknowriad
changed the title
* Upgrade React to 16.8.4 * Update package-lock.json file * Expose React Hooks
youknowriad
force-pushed
the
update/react-16.8-try-2
branch
from
dd24509 to
630e7bb
Compare
package-lock.json
Outdated
| "react": "^16.8.4", | ||
| "react-dom": "^16.8.4" | ||
| }, | ||
| "dependencies": { |
There was a problem hiding this comment.
This part should be manually removed. The same versions of packages are now in the root of the lock file.
There was a problem hiding this comment.
Why do we need to do these manual tweaks? It seems to work as is?
There was a problem hiding this comment.
Oh I think it's because they're considered "dev" dependencies at the root level, this means npm marks them as "dev": true, at the root level but also add them here as normal dependencies. I think we should keep them as is.
| "react-test-renderer": "16.6.3", | ||
| "react": "16.8.4", | ||
| "react-dom": "16.8.4", | ||
| "react-test-renderer": "16.8.4", |
There was a problem hiding this comment.
It's surprising that react-test-renderer wasn't listed before 🤷♂️
There was a problem hiding this comment.
react wasn't listed before.
|
I added cd61281 which performs some cleanup to ensure we use only one version of React dependencies. |
|
|
||
| [src/index.js#L1-L1](src/index.js#L1-L1) | ||
|
|
||
| Make React Hooks available |
There was a problem hiding this comment.
These aren't the most helpful documentation.
There was a problem hiding this comment.
Mmm Right I didn't notice, we might want to just link to the React Docs here. how can we improve this, I'm not yet familiar with this new doc generator @nosolosw
There was a problem hiding this comment.
We can do a couple of options:
-
Change this comment to Refer to React docs https://reactjs.org/docs/hooks-reference.html. That'd the quick/easy way.
-
Export every item independently as we did with the others. In the JSDoc comment, we can refer to the specific React hook reference like
@see https://reactjs.org/docs/hooks-reference.html#usecallback.
There was a problem hiding this comment.
I'm preparing a PR for the second option.
There was a problem hiding this comment.
Awesome Thank you :)
There was a problem hiding this comment.
#14425 could be the minimum viable docs.
…/fix-develop Merge up until just before "Upgrade React to 16.8.4: Welcome React Hooks (#14400)"
|
At the risk of stating the obvious, it should be noted that in bringing |
ghost
mentioned this pull request
Second attempt to upgrade React. Now that react-native 0.59 stable is out, we can move forward with the web. The mobile team can update when they sync master to develop.