Improve openAllBlockInserterCategories function;

[jorgefilipecosta]

Fix intermittent failures in inner-blocks-allowed-blocks.test.js.

How has this been tested?

The best method seems to be executing this test in Travis CI multiple times and check that the tests don't fail.

[afercia]

To my understanding, for some reasons the name of this branch fix/intermitent-failures-in-inner-blocks-allowed-blocks.test.js (notice the part blocks.test.js) makes npm test fail locally for me. Seems the .git folder is not excluded 😬 and npm test tries to run it as it was a test file. Console output:

Summary of all failing tests
 FAIL  .git/logs/refs/remotes/origin/fix/intermitent-failures-in-inner-blocks-allowed-blocks.test.js
  ● Test suite failed to run

    SyntaxError: /Users/andrea/wp/plugins/gutenberg/.git/logs/refs/remotes/origin/fix/intermitent-failures-in-inner-blocks-allowed-blocks.test.js: Legacy octal literals are not allowed in strict mode (1:0)

    etc...

 FAIL  .git/refs/remotes/origin/fix/intermitent-failures-in-inner-blocks-allowed-blocks.test.js
  ● Test suite failed to run

    SyntaxError: /Users/andrea/wp/plugins/gutenberg/.git/refs/remotes/origin/fix/intermitent-failures-in-inner-blocks-allowed-blocks.test.js: Identifier directly after number (1:4)

    etc...

[gziolo]

I can confirm that it solves the original issue. I'm not 100% confident about using while loop but maybe it's okay given that Jest sets a timeout for each test.

[gziolo]

How about we keep the for of loop and we wait until it has is-opened class applied? I never feel confident about using while loop :)
I'm not sure to be honest, maybe this is okay since it has to await and would timeout anyways.

[jorgefilipecosta]

I think this approach would still be problematic, because if we used the selector '.block-editor-inserter__results .components-panel__body' in a for of, as soon as we applied the first click, all the other selectors would be invalid, because they reference an element that no longer exists on the dom because of a rerender that happens on click so we would not be able to use the element to wait for a class.

[gziolo]

Yeah, it's a complex stuff :)

[jorgefilipecosta]

Merging this so we can delete the branch and avoid problems like the one referred by @afercia. If anyone has more thoughts on this I will gladly iterate.
Thank you for sharing this problem @afercia I will avoid branch with names like this in the future, and I will look into a way to exclude the git folder.