Docs: Include clarification about using @wordpress/babel-plugin-import-jsx-pragma with @wordpress/babel-preset-default #14482
Conversation
…t-jsx-pragma with @wordpress/babel-preset-default
gziolo
requested review from
aduth,
ajitbohra,
nerrad,
oandregal,
ntwb and
youknowriad
as code owners
| @@ -30,6 +30,8 @@ module.exports = { | |||
| }; | |||
| ``` | |||
|
|
|||
| _Note:_ `@wordpress/babel-plugin-import-jsx-pragma` is now included in `@wordpress/babel-preset-default` (default preset for WordPress development). If you are using it, you shouldn't need to include this plugin anymore in your Babel config. | |||
There was a problem hiding this comment.
This reads as a temporary note which won't age well. Do we have a planned schedule on if / when it would no longer be valuable to include?
There was a problem hiding this comment.
I didn't think about it initially. However, I agree with your point, we should remove it in a month or something like that. I added it to my todo list. Should I open PR with a related description?
There was a problem hiding this comment.
I didn't think about it initially. However, I agree with your point, we should remove it in a month or something like that. I added it to my todo list. Should I open PR with a related description?
I don't have a strong preference on timeline; I personally don't think the note was needed in the first place† 😅 A month can be fine. If we're soon to publish packages going into feature freeze, I suppose it could be merged immediately afterward, with the assumption the next publish wouldn't be for some time. Otherwise it becomes an issue of how do we keep the schedule.
† To me, the perfect scenario would be that the plugin gracefully handles the case that it's included twice. The next best thing would be a clear note that the preset and plugin cannot be used in combination. Re-reading this text, I think it's fairly clear. It may have just been that the phrases "now" and "anymore" caught my attention as sounding temporary and not associated with any sense of when "now" actually occurred. "As of vX.X.X" might have served as an alternative pinned to a specific point in time.
gziolo
added
the
[Tool] Babel plugin import JSX pragma
…t-jsx-pragma with @wordpress/babel-preset-default (#14482)
…t-jsx-pragma with @wordpress/babel-preset-default (#14482)
Description
Closes #14381. Improves our docs to make it easier to resolve potential conflicts when upgrading
@wordpress/babel-preset-defaultfrom version < 4.0.0 to the latest version when using with@wordpress/babel-plugin-import-jsx-pragma.