Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes unwanted theme specific Column bottom margin #14614

Merged
merged 2 commits into from
Mar 30, 2019
Merged

Removes unwanted theme specific Column bottom margin #14614

merged 2 commits into from
Mar 30, 2019

Conversation

getdave
Copy link
Contributor

@getdave getdave commented Mar 25, 2019

Restores margin to original spacing value. Removes unwanted additional margin on last child.

Description

Addresses #14596

@getdave
Removes unwanted theme specific Column bottom margin
3772b9c 
Restores margin to original spacing value. Removes unwanted additional margin on last child.
@getdave getdave added the [Block] Columns Affects the Columns Block label Mar 25, 2019
@getdave getdave self-assigned this Mar 25, 2019
@getdave getdave mentioned this pull request Mar 25, 2019
Closed
@getdave getdave requested review from jasmussen and aduth and removed request for aduth March 26, 2019 09:29
@getdave getdave added the [Type] Bug An existing feature does not function as intended label Mar 26, 2019
@jasmussen
Copy link
Contributor

Nice, this seems okay. Is there any overlap with #14407? Have you tested obscure combinations of blocks, such as paragraph, columns block with tons of inner paragraphs, then paragraphs after? how about images before and after columns block and images inside? If all's good then this PR is probably all good too.

@getdave
Copy link
Contributor Author

getdave commented Mar 27, 2019

Is there any overlap with #14407?

This PR only removes the superfluous line (that was added recently here) that targeted the Theme directly. I think it was when I was testing against Twenty Nineteen.

Should have no impact elsewhere.

jasmussen
jasmussen approved these changes Mar 28, 2019
View reviewed changes
Copy link
Contributor

@jasmussen jasmussen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it.

@jasmussen jasmussen added this to the 5.4 (Gutenberg) milestone Mar 28, 2019
@getdave getdave mentioned this pull request Mar 29, 2019
Merged
15 tasks
@youknowriad youknowriad merged commit 18b4305 into master Mar 30, 2019
@youknowriad youknowriad deleted the fix/remove-theme-specific-column-margin branch March 30, 2019 13:55
@noisysocks noisysocks mentioned this pull request Apr 1, 2019
Merged
@getdave
Copy link
Contributor Author

getdave commented Apr 1, 2019

Thanks @noisysocks. I was waiting on tests to pass which were taking ages to run. Appreciate your handling this.

@noisysocks noisysocks mentioned this pull request Apr 3, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-e-h m-e-h m-e-h left review comments

@jasmussen jasmussen jasmussen approved these changes

@chrisvanpatten chrisvanpatten Awaiting requested review from chrisvanpatten

Assignees

@getdave getdave

Labels
[Block] Columns Affects the Columns Block [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
5.4 (Gutenberg)
Development

Successfully merging this pull request may close these issues.
4 participants
@getdave @jasmussen @m-e-h @youknowriad