Fix radio button appearance on small screens #14624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjellr
added
[Type] Bug
|
I'm not entirely sure why I'm seeing this, but in master I'm currently seeing this:
That's fullscreen, not sure if that matters. |
kjellr
added a commit
that referenced
this pull request
Mar 28, 2019
PR #14624 mistakenly used negative pixel values for the position of the dot inside of radio buttons. This PR restores the correct values, to ensure proper placement.
|
Good catch, @jasmussen! For some reason, I used negative margins here instead of positive ones. 😅 The fix is over in #14684. |
kjellr
added a commit
that referenced
this pull request
Mar 28, 2019
PR #14624 mistakenly used negative pixel values for the position of the dot inside of radio buttons. This PR restores the correct values, to ensure proper placement.
This was referenced Apr 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Radio buttons and checkboxes currently appear
25pxwide on mobile screens, and16pxwide on larger screens.In the case of the radio button, the
:beforepseudo element that forms the circle inside of it does not have mobile styles, leading to an off-centered placement:This PR adds styles to correct that, mirroring what we do for checkboxes already:
To test:
782pxwide.