Fix styling regression to autocompleters #14791
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Bug
talldan
commented
Apr 3, 2019
| @@ -54,7 +54,7 @@ export function createBlockCompleter( { | |||
| } = {} ) { | |||
| return { | |||
| name: 'blocks', | |||
| className: 'editor-autocompleters__block', | |||
| className: 'block-editor-autocompleters__block', | |||
There was a problem hiding this comment.
Should I have gone with block-editor, editor (changing the stylesheet instead), or both?
There was a problem hiding this comment.
It seems like we should go with editor as we're declaring these in the editor module. Not sure why these classNames were changed.
|
This appears to be a duplicate of #14772 |
|
Let's go with #14772 . I've pushed commits for the revised proposal, which is as you mention in #14791 (comment) with "changing the stylesheet instead" (credited as co-authored commit). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The styles of the autocompleters (slash inserter autocompleter and
@user autocompleter) regressed recently, and it looks like it was caused by the block-editor refactor. Some classnames were updated toblock-editorin SCSS, but not in JS. I've updated them to use theblock-editorprefix. However, as these components are still in theeditorpackage, maybe I should have gone with theeditorprefix instead?How has this been tested?
/in a new paragraph. Observe that block icons in the autocompletion menu have correct padding.@in a new paragraph. Observe that icons and text in the autocompletion menu have correct padding/spacing.Screenshots
Slash inserter before regression
Slash inserter after regression
Slash inserter after fix
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: