-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugin: Update package-lock.json #14808
Conversation
Ah, this is probably why: Line 35 in b3961d0
Edit: Hmm, but it is supposed to exit with error status code if |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Sorry about that. Would be good to make Travis return an error. :)
Yeah, I'm not really sure what's going on there, even after digging further into how Travis handles errors. Based on how some other projects explicitly incorporate |
Hm, but that still wouldn't explain |
It could, since Line 18 in 5cf4e14
|
Previously: https://github.com/WordPress/gutenberg/pull/14664/files#r271885310
This pull request seeks to update
package-lock.json
file per dependency changes in #14664.Separately, we should explore why the
check-local-changes
npm script is not correctly identifying local changes in Travis.