Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block Library: Display ButtonBlockAppender only if selected or empty #14966

Closed
wants to merge 1 commit into from
Closed

Block Library: Display ButtonBlockAppender only if selected or empty #14966

wants to merge 1 commit into from

Conversation

aduth
Copy link
Member

@aduth aduth commented Apr 12, 2019

Merges to #14943 as base branch.

WIP: Experimenting to conditionally render ButtonBlockAppender only if selected or empty.

@aduth aduth added [Status] In Progress Tracking issues with work in progress [Package] Block library /packages/block-library labels Apr 12, 2019
@aduth aduth mentioned this pull request Apr 12, 2019
Merged
5 tasks
@talldan
Copy link
Contributor

talldan commented Apr 18, 2019

Thanks for this! I've cherry-picked 3396d96 into the branch for #14943.

@aduth
Copy link
Member Author

aduth commented Apr 18, 2019

Closing in favor of #14943.

@aduth aduth closed this Apr 18, 2019
@aduth aduth deleted the try/group-button-appender-selected-or-empty branch April 18, 2019 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
[Package] Block library /packages/block-library [Status] In Progress Tracking issues with work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aduth @talldan