removes the dev mode access key binding safeguard #15044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
draganescu
requested review from
aduth,
ajitbohra,
chrisvanpatten,
gziolo,
jorgefilipecosta,
noisysocks,
talldan and
youknowriad
as code owners
|
Check |
|
Experienced this problem myself, and can confirm removing the check fixes the issue. I'm open to a different approach if it still works on non-Apple OS :) |
|
@ellatrix @draganescu any more thoughts to this? Is there any other approach? It's getting annoying not to be able to develop Gutenberg unless I have this patch applied :) |
draganescu
force-pushed
the
update/remove-shortcut-dev-safeguard
branch
from
5c7659c to
e4d7530
Compare
|
I've redone this with adding a check for Apple platform, I would need someone to confirm it is working on other systems and not throwing an error anymore. @ellatrix if it looks good to you maybe you can approve this? |
|
I can confirm this works in Ubuntu OS (Linux). |
ellatrix
reviewed
Apr 24, 2019
ellatrix
reviewed
Apr 25, 2019
| /** | ||
| * Return true if platform is MacOS. | ||
| * | ||
| * @param {Object} _window window object by default; used for DI testing. |
There was a problem hiding this comment.
We're not using it here, so it can be removed?
ellatrix
approved these changes
Apr 25, 2019
oandregal
approved these changes
Apr 25, 2019
This was referenced Apr 29, 2019
This was referenced Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This removes the safeguard introduced in #14681 that would prevent devs to assign shortcuts containing alt + shift. All shortcuts that use the
accesskey will be alt shift on linux and windows and ctrl alt on mac. Throwing therefore the error would require to check that the current env is apple but would not prevent someone on, say, linux to set it.@ellatrix if you have any other idea it'd be great :)