Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing: Skip unreliable end-to-end tests #15059

Merged
merged 1 commit into from
Apr 18, 2019
Merged

Testing: Skip unreliable end-to-end tests #15059

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/e2e-tests/specs/block-deletion.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ describe( 'block deletion -', () => {
beforeEach( addThreeParagraphsToNewPost );

describe( 'deleting the third block using the Remove Block menu item', () => {
it( 'results in two remaining blocks and positions the caret at the end of the second block', async () => {
it.skip( 'results in two remaining blocks and positions the caret at the end of the second block', async () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The one I'm hesitant because in my experience at least it has shown to be unreliable only when using "popular plugins" and the fact that the popular plugins test didn't prove to be succesful IMO, I wonder if we should remove those instead.

// The blocks can't be empty to trigger the toolbar
await page.keyboard.type( 'Paragraph to remove' );

Expand Down
6 changes: 3 additions & 3 deletions packages/e2e-tests/specs/embedding.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@ describe( 'Embedding content', () => {
await page.waitForSelector( '.wp-block-embed-wordpress' );
} );

it( 'should transform from video to embed block when YouTube URL is pasted', async () => {
it.skip( 'should transform from video to embed block when YouTube URL is pasted', async () => {
await clickBlockAppender();
await insertBlock( 'Video' );
await page.click( '.editor-media-placeholder__url-input-container button' );
Expand All @@ -281,7 +281,7 @@ describe( 'Embedding content', () => {
await page.waitForSelector( '.wp-block-embed-youtube' );
} );

it( 'should transform from image to embed block when Instagram URL is pasted', async () => {
it.skip( 'should transform from image to embed block when Instagram URL is pasted', async () => {
await clickBlockAppender();
await page.keyboard.type( '/image' );
await page.keyboard.press( 'Enter' );
Expand All @@ -291,7 +291,7 @@ describe( 'Embedding content', () => {
await page.waitForSelector( '.wp-block-embed-instagram' );
} );

it( 'should transform from audio to embed block when Soundcloud URL is pasted', async () => {
it.skip( 'should transform from audio to embed block when Soundcloud URL is pasted', async () => {
await clickBlockAppender();
await page.keyboard.type( '/audio' );
await page.keyboard.press( 'Enter' );
Expand Down
3 changes: 1 addition & 2 deletions packages/e2e-tests/specs/links.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,8 +266,7 @@ describe( 'Links', () => {
};

// Test for regressions of https://github.com/WordPress/gutenberg/issues/10496.
// Disabled until improved as it wasn't reliable enough.
it( 'allows autocomplete suggestions to be selected with the mouse', async () => {
it.skip( 'allows autocomplete suggestions to be selected with the mouse', async () => {
// First create a post that we can search for using the link autocompletion.
const titleText = 'Test post mouse';
const postURL = await createPostWithTitle( titleText );
Expand Down