Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try tweaking the specificity of the custom color syntax #15167

Merged
merged 3 commits into from
May 3, 2019
Merged

Try tweaking the specificity of the custom color syntax #15167

merged 3 commits into from
May 3, 2019

Conversation

jasmussen
Copy link
Contributor

This fixes #12986 and is based on the conversation there.

Instead of doubling the selectors to increase specificity, we are supplying the element as well.

Try tweaking the specificity of the custom color syntax
ab5e32c 
This fixes #12986 and is based on the conversation there.

Instead of doubling the selectors to increase specificity, we are supplying the element as well.
@jasmussen jasmussen added [Status] In Progress Tracking issues with work in progress [Type] Code Quality Issues or PRs that relate to code quality labels Apr 25, 2019
@jasmussen jasmussen self-assigned this Apr 25, 2019
@jasmussen jasmussen mentioned this pull request Apr 25, 2019
Closed
@jasmussen jasmussen removed the [Status] In Progress Tracking issues with work in progress label Apr 30, 2019
@jasmussen jasmussen marked this pull request as ready for review April 30, 2019 09:03
@jasmussen
Copy link
Contributor Author

Thanks for the review! Addressed the points.

jorgefilipecosta
jorgefilipecosta approved these changes May 3, 2019
View reviewed changes
Copy link
Member

@jorgefilipecosta jorgefilipecosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 The specificity is not changed so users should not notice any difference.

@jasmussen jasmussen added this to the 5.7 (Gutenberg) milestone May 3, 2019
@jasmussen jasmussen merged commit 42eb03c into master May 3, 2019
@jasmussen jasmussen deleted the try/tweak-color-override-css branch May 3, 2019 15:45
@jasmussen jasmussen mentioned this pull request May 10, 2019
Closed
@oandregal oandregal mentioned this pull request Apr 29, 2020
Merged
@oandregal oandregal mentioned this pull request May 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgefilipecosta jorgefilipecosta jorgefilipecosta approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@gziolo gziolo Awaiting requested review from gziolo

@noisysocks noisysocks Awaiting requested review from noisysocks

@notnownikki notnownikki Awaiting requested review from notnownikki

@Soean Soean Awaiting requested review from Soean

@talldan talldan Awaiting requested review from talldan

@youknowriad youknowriad Awaiting requested review from youknowriad

Assignees

@jasmussen jasmussen

Labels
[Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
5.7 (Gutenberg)
Development

Successfully merging this pull request may close these issues.

.has-vivid-cyan-blue-background-color.has-vivid-cyan-blue-background-color
3 participants
@jasmussen @m-e-h @jorgefilipecosta