Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mobile] Move unselected block accessibility handling to block-holder (v2) #15225

Merged
merged 14 commits into from
Jun 6, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
129 changes: 48 additions & 81 deletions packages/block-library/src/heading/edit.native.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,94 +8,61 @@ import styles from './editor.scss';
* External dependencies
*/
import { View } from 'react-native';
import { isEmpty } from 'lodash';

/**
* WordPress dependencies
*/
import { __, sprintf } from '@wordpress/i18n';
import { Component } from '@wordpress/element';
import { __ } from '@wordpress/i18n';
import { RichText, BlockControls } from '@wordpress/block-editor';
import { createBlock } from '@wordpress/blocks';
import { create } from '@wordpress/rich-text';

class HeadingEdit extends Component {
plainTextContent( html ) {
const result = create( { html } );
if ( result ) {
return result.text;
}
return '';
}

render() {
const {
attributes,
setAttributes,
mergeBlocks,
style,
onReplace,
} = this.props;

const {
level,
placeholder,
content,
} = attributes;

const tagName = 'h' + level;

return (
<View
accessible={ ! this.props.isSelected }
accessibilityLabel={
isEmpty( content ) ?
sprintf(
/* translators: accessibility text. %s: heading level. */
__( 'Heading block. Level %s. Empty.' ),
level
) :
sprintf(
/* translators: accessibility text. 1: heading level. 2: heading content. */
__( 'Heading block. Level %1$s. %2$s' ),
level,
this.plainTextContent( content )
)
const HeadingEdit = ( {
attributes,
isSelected,
mergeBlocks,
onBlur,
onFocus,
onReplace,
setAttributes,
style,
} ) => (
<View onAccessibilityTap={ onFocus }>
<BlockControls>
<HeadingToolbar
minLevel={ 2 }
maxLevel={ 5 }
selectedLevel={ attributes.level }
onChange={ ( newLevel ) => setAttributes( { level: newLevel } ) }
/>
</BlockControls>
<RichText
identifier="content"
tagName={ 'h' + attributes.level }
value={ attributes.content }
isSelected={ isSelected }
style={ {
...style,
minHeight: styles[ 'wp-block-heading' ].minHeight,
} }
onFocus={ onFocus } // always assign onFocus as a props
onBlur={ onBlur } // always assign onBlur as a props
onChange={ ( value ) => setAttributes( { content: value } ) }
onMerge={ mergeBlocks }
onSplit={ ( value ) => {
if ( ! value ) {
return createBlock( 'core/paragraph' );
}
onAccessibilityTap={ this.props.onFocus }
>
<BlockControls>
<HeadingToolbar minLevel={ 2 } maxLevel={ 5 } selectedLevel={ level } onChange={ ( newLevel ) => setAttributes( { level: newLevel } ) } />
</BlockControls>
<RichText
identifier="content"
tagName={ tagName }
value={ content }
isSelected={ this.props.isSelected }
style={ {
...style,
minHeight: styles[ 'wp-block-heading' ].minHeight,
} }
onFocus={ this.props.onFocus } // always assign onFocus as a props
onBlur={ this.props.onBlur } // always assign onBlur as a props
onChange={ ( value ) => setAttributes( { content: value } ) }
onMerge={ mergeBlocks }
onSplit={ ( value ) => {
if ( ! value ) {
return createBlock( 'core/paragraph' );
}

return createBlock( 'core/heading', {
...attributes,
content: value,
} );
} }
onReplace={ onReplace }
onRemove={ () => onReplace( [] ) }
placeholder={ placeholder || __( 'Write heading…' ) }
/>
</View>
);
}
}
return createBlock( 'core/heading', {
...attributes,
content: value,
} );
} }
onReplace={ onReplace }
onRemove={ () => onReplace( [] ) }
placeholder={ attributes.placeholder || __( 'Write heading…' ) }
/>
</View>
);

export default HeadingEdit;
39 changes: 39 additions & 0 deletions packages/block-library/src/heading/index.native.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
/**
* External dependencies
*/
import { isEmpty } from 'lodash';

/**
* WordPress dependencies
*/
import { __, sprintf } from '@wordpress/i18n';
import { create } from '@wordpress/rich-text';

/**
* Internal dependencies
*/
import { settings as webSettings } from './index.js';

export { metadata, name } from './index.js';

export const settings = {
...webSettings,
__experimentalGetAccessibilityLabel( attributes ) {
const { content, level } = attributes;

const plainTextContent = ( html ) => create( { html } ).text || '';

return isEmpty( content ) ?
sprintf(
/* translators: accessibility text. %s: heading level. */
__( 'Level %s. Empty.' ),
level
) :
sprintf(
/* translators: accessibility text. 1: heading level. 2: heading content. */
__( 'Level %1$s. %2$s' ),
level,
plainTextContent( content )
);
},
};
7 changes: 0 additions & 7 deletions packages/block-library/src/image/edit.native.js
Original file line number Diff line number Diff line change
Expand Up @@ -273,13 +273,6 @@ class ImageEdit extends React.Component {
const getImageComponent = ( openMediaOptions, getMediaOptions ) => (
<TouchableWithoutFeedback
accessible={ ! isSelected }
accessibilityLabel={ sprintf(
/* translators: accessibility text. 1: image alt text. 2: image caption. */
__( 'Image block. %1$s. %2$s' ),
alt,
caption
) }
accessibilityRole={ 'button' }
onPress={ this.onImagePressed }
onLongPress={ openMediaOptions }
disabled={ ! isSelected }
Expand Down
30 changes: 30 additions & 0 deletions packages/block-library/src/image/index.native.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
/**
* WordPress dependencies
*/
import { __ } from '@wordpress/i18n';

/**
* Internal dependencies
*/
import { settings as webSettings } from './index.js';

export { metadata, name } from './index.js';

export const settings = {
...webSettings,
__experimentalGetAccessibilityLabel( attributes ) {
const { caption, alt, url } = attributes;

if ( ! url ) {
return __( 'Empty' );
}

if ( ! alt ) {
return caption || '';
}

// This is intended to be read by a screen reader.
// A period simply means a pause, no need to translate it.
return alt + ( caption ? '. ' + caption : '' );
},
};
17 changes: 2 additions & 15 deletions packages/block-library/src/missing/edit.native.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import { Icon } from '@wordpress/components';
import { coreBlocks } from '@wordpress/block-library';
import { normalizeIconObject } from '@wordpress/blocks';
import { Component } from '@wordpress/element';
import { __, sprintf } from '@wordpress/i18n';
import { __ } from '@wordpress/i18n';

/**
* Internal dependencies
Expand All @@ -25,20 +25,7 @@ export default class UnsupportedBlockEdit extends Component {
const icon = blockType ? normalizeIconObject( blockType.settings.icon ) : 'admin-plugins';

return (
<View style={ styles.unsupportedBlock }
accessible={ true }
accessibilityLabel={
blockType ?
sprintf(
/* translators: accessibility text. %s: unsupported block type. */
__( 'Unsupported block: %s' ),
title
) :
/* translators: accessibility text. */
__( 'Unsupported block' )
}
onAccessibilityTap={ this.props.onFocus }
>
<View style={ styles.unsupportedBlock }>
<Icon className="unsupported-icon" icon={ icon && icon.src ? icon.src : icon } />
<Text style={ styles.unsupportedBlockMessage }>{ title }</Text>
</View>
Expand Down
27 changes: 2 additions & 25 deletions packages/block-library/src/paragraph/edit.native.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,14 @@
* External dependencies
*/
import { View } from 'react-native';
import { isEmpty } from 'lodash';

/**
* WordPress dependencies
*/
import { __, sprintf } from '@wordpress/i18n';
import { __ } from '@wordpress/i18n';
import { Component } from '@wordpress/element';
import { createBlock } from '@wordpress/blocks';
import { RichText } from '@wordpress/block-editor';
import { create } from '@wordpress/rich-text';

/**
* Internal dependencies
Expand Down Expand Up @@ -39,14 +37,6 @@ class ParagraphEdit extends Component {
) ) );
}

plainTextContent( html ) {
const result = create( { html } );
if ( result ) {
return result.text;
}
return '';
}

render() {
const {
attributes,
Expand All @@ -62,20 +52,7 @@ class ParagraphEdit extends Component {
} = attributes;

return (
<View
accessible={ ! this.props.isSelected }
accessibilityLabel={
isEmpty( content ) ?
/* translators: accessibility text. empty paragraph block. */
__( 'Paragraph block. Empty' ) :
sprintf(
/* translators: accessibility text. %s: text content of the paragraph block. */
__( 'Paragraph block. %s' ),
this.plainTextContent( content )
)
}
onAccessibilityTap={ this.props.onFocus }
>
<View>
<RichText
identifier="content"
tagName="p"
Expand Down
28 changes: 28 additions & 0 deletions packages/block-library/src/paragraph/index.native.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
/**
* External dependencies
*/
import { isEmpty } from 'lodash';

/**
* WordPress dependencies
*/
import { __ } from '@wordpress/i18n';
import { create } from '@wordpress/rich-text';

/**
* Internal dependencies
*/
import { settings as webSettings } from './index.js';

export { metadata, name } from './index.js';

export const settings = {
...webSettings,
__experimentalGetAccessibilityLabel( attributes ) {
const { content } = attributes;

const plainTextContent = ( html ) => create( { html } ).text || '';

return isEmpty( content ) ? __( 'Empty' ) : plainTextContent( content );
},
};