[RNMobile] fork master before richtext selection state change #15399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add accessibilityLabel to post title * Update accessibilityLabel * Update accessibilityLabel * Remove unnecessary line * Import sprintf from i18n
* Adding accessibility properties to MediaPlaceholder and ImageEdit * Fix lint issues * Fix typo * Better accessibility labels * Disable lists. (#14844) * Fix scroll with VoiceOver ON. For some reason, VoiceOver wouldn't scroll down the block list. The breaking change was located at the removal of this css property `font-family: $default-regular-font;` on the nextpage block. Addinb back that property to be able to scroll the blocks list again using VoiceOver. * Setting accessibilityStates properly to avoid Android crash * Remove vscode settings file (added by mistake) * Fix lint issues * Update accessibility labels to use sprintf * Fix lint issues
… of the editor (#15055) * Do not reset the content in onSelectionChange * Make sure there are changes made to the content before upgrading it upward * Refactor: Introduce a local variable and DRY the code a bit * Fix lint
* Add accessibility label for unselected state * Improve accessibility handling
* Enhance accessibility on toolbar buttons * Add accessibilityLabel for Image * Add accessibility on caption * Remove unnecessary hints * Update accessibility labels * Remove unnecessary hint
* Make a11y string properly localizable * Remove extra . after the content * Add `accessibility text` to the translators comment * Fix the wrong parameter * Change the position of translator comments
* Make accessibility labels properly localizable * Fix indentation * Fix image block accessibility labels
* RNMobile: Add ability to send extra props (i.e. props needed just for mobile) to the list block. * Adding onCaretVerticalPositionChange to RichText via context * Passing onCaretVerticalPositionChange via context to RichText for all RichText based blocks This makes it not necessary to pass onCaretVerticalPositionChange as a prop directly to RichText from the block component. * Update jest snapshot for block-edit
* If text already changed, don't modify it * Able to not lose content * Use a flag to signal Aztec-originated changes And assume that when that flag is false, component changes need to get sent/reflected down to Aztec. * Differentiate Android and iOS since assumptions diverged The iOS side still expects to just check against `this.lastContent` to force the change into Aztec. * Force Aztec update if "Enter" fired before text change * Need to specify firedAfterTextChanged on all Aztec events * Fix lint issues * chore: Fix: Lint error that makes unit tests (and CI tests) fail. (#15073) * Trivial change to trigger Travis * Revert "Trivial change to trigger Travis" This reverts commit e22ffde. * Just use onFormatChange which now defaults to "force" * Have Aztec delete the detected Enter key for paragraphs Aztec-Android doesn't swallow the Enter key (like the list handling does) so, instruct Aztec to delete it for the paragraph block. * Don't force Aztec update on format button toggles Doing this by reverting onFormatChange's behavior back to assuming doUpdateChild is false by default.
hypest
changed the title
* Add safety check to image url before calling indexOf * Set attributes.id to null when an image upload is cancelled * Add console.warn and comments to help track WordPress-Android issue #9768 * Fix lint errors
gziolo
added
the
Mobile App - i.e. Android or iOS
|
Is it sill necessary? It has been a while since it was created. |
gziolo
added
the
[Status] Stale
|
Closing since it's not needed anymore |
etoledom
deleted the
rnmobile/master-fork-before-richtext-selection-state-change
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR contains a "stripped" down version of
masterthat only contains the RNMobile merges, and leaving out all web-side work since this PR: #14640 which is causing a breakage to the native mobile side.This PR should not be merged. Instead, it serves for tracking the work on this special branch and will be used for the next native mobile code freeze.
How has this been tested?
Manually against gutenberg-mobile
develop.Types of changes
Removes all web-side merged commits after (and including) #14640
Checklist: