Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: webpack does not watch for block.json changes #15455

Merged
merged 1 commit into from
May 6, 2019
Merged

Fix: webpack does not watch for block.json changes #15455

merged 1 commit into from
May 6, 2019

Conversation

gziolo
Copy link
Member

@gziolo gziolo commented May 6, 2019

Fixes #15135:

Describe the bug*
Since #14770, the block.json is introduced. However, the webpack does not watch for the json files changes.

To reproduce
Steps to reproduce the behavior:

  1. npm run dev
  2. modify a block.json file
    The webpack does not rebuild the package automatically.

Testing

  1. npm run dev
  2. modify any block.json file
  3. confirm that webpack rebuild files

@gziolo gziolo added [Type] Bug An existing feature does not function as intended [Type] Build Tooling Issues or PRs related to build tooling labels May 6, 2019
@gziolo gziolo mentioned this pull request May 6, 2019
Closed
@gziolo gziolo merged commit 61a64db into master May 6, 2019
@gziolo gziolo deleted the fix/json-watch-packages branch May 6, 2019 15:23
@gziolo gziolo added this to the 5.7 (Gutenberg) milestone May 6, 2019
@swissspidy swissspidy mentioned this pull request Jun 12, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youknowriad youknowriad youknowriad approved these changes

@aduth aduth Awaiting requested review from aduth

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@nerrad nerrad Awaiting requested review from nerrad

@ntwb ntwb Awaiting requested review from ntwb

Assignees
No one assigned
Labels
[Type] Bug An existing feature does not function as intended [Type] Build Tooling Issues or PRs related to build tooling
Projects
None yet
Milestone
5.7 (Gutenberg)
Development

Successfully merging this pull request may close these issues.

Webpack does not watch for block.json changes
2 participants
@gziolo @youknowriad