Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add back focus style to Document Outline panel #15479

Merged
merged 1 commit into from
May 8, 2019
Merged

Add back focus style to Document Outline panel #15479

merged 1 commit into from
May 8, 2019

Conversation

jasmussen
Copy link
Contributor

This PR intends to, and maybe fixes #15324. That is, it restores the focus outline style to the document outline popover which regressed.

GIF:

focus

Add back focus style to Document Outline panel
2105dfd 
This PR intends to, and maybe fixes #15324. That is, it restores the focus outline style to the document outline popover which regressed.
@jasmussen jasmussen added [Feature] Document Outline An option that outlines content based on a title and headings used in the post/page [Type] Regression Related to a regression in the latest release labels May 7, 2019
@jasmussen jasmussen self-assigned this May 7, 2019
@jasmussen jasmussen mentioned this pull request May 7, 2019
Closed
@jorgefilipecosta jorgefilipecosta added the [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). label May 7, 2019
jorgefilipecosta
jorgefilipecosta approved these changes May 7, 2019
View reviewed changes
Copy link
Member

@jorgefilipecosta jorgefilipecosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as advertised and the code change looks good to me 👍

@jasmussen jasmussen added this to the 5.7 (Gutenberg) milestone May 8, 2019
@jasmussen jasmussen merged commit 33208ba into master May 8, 2019
@jasmussen jasmussen deleted the fix/outline-focus branch May 8, 2019 06:30
@gziolo gziolo mentioned this pull request May 8, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgefilipecosta jorgefilipecosta jorgefilipecosta approved these changes

@noisysocks noisysocks Awaiting requested review from noisysocks

@talldan talldan Awaiting requested review from talldan

@youknowriad youknowriad Awaiting requested review from youknowriad

Assignees

@jasmussen jasmussen

Labels
[Feature] Document Outline An option that outlines content based on a title and headings used in the post/page [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Regression Related to a regression in the latest release
Projects
None yet
Milestone
5.7 (Gutenberg)
Development

Successfully merging this pull request may close these issues.

Focus not visible on Content Structure pane
2 participants
@jasmussen @jorgefilipecosta