Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move "continue writing" next to inserter and show on hover. #1553

Merged
merged 4 commits into from
Jun 28, 2017

Conversation

mtias
Copy link
Member

@mtias mtias commented Jun 28, 2017

image

@mtias mtias added Design [Status] In Progress Tracking issues with work in progress labels Jun 28, 2017
@nylen
Copy link
Member

nylen commented Jun 28, 2017

Related: #1501, #1502

@mtias
Copy link
Member Author

mtias commented Jun 28, 2017

Another exploration: https://cloudup.com/cHelDRmdj11

@jasmussen
Copy link
Contributor

I like the other exploration.

The problem we want to solve is very specific: if a non-text block is the last block in the list, you should have an easier way to continue writing text, than to first have to click Insert > Text.

The "Continue writing..." did this, though I agree perhaps not in an elegant way. Both solutions presented here address this also.

In the past, ideas similar to your "other exploration" have been brought up. I can't recall the specific people who suggested it, but @shaunandrews and @paaljoachim come to mind. My concern back then was that this area below the inserter showed n recent blocks, and that these were always visible. I was against this because I was concerned this area would quickly get cluttered, in an editor that is already very rich on interface. Also because if the blocks here changed per recency, you wouldn't be able to develop any spatial memory.

The fading out of everything but the plus, as well as the fact that there are only two blocks there — text and image — feels like it can address those concerns. In recognizing that I was probably wrong to disagree with the ideas presented by Shaun and Joachim (and maybe others) in the past, here's an acknowledgement that you were all probably on to something, and I was probably wrong.

Therefore, thumbs up from me, provided this can be made accessible (if it isn't already, it possibly is), let's try this and iterate.

@mtias mtias force-pushed the try/different-continue-writing branch from 8eb1e0b to 7d15a80 Compare June 28, 2017 15:07
@jasmussen
Copy link
Contributor

Looks good in latest version! Remember to use $default-font for the buttons there, so they get to be system fonts (because it's UI).

@mtias
Copy link
Member Author

mtias commented Jun 28, 2017

Push failed :)

@paaljoachim
Copy link
Contributor

paaljoachim commented Jun 29, 2017

I added the wireframe of having the image and text block show up when clicking/hovering the inserter as a way to avoid having the continue writing block show up. It would seem less intrusive on the user. I was not sure if I liked it or not, but Mathias exploration looks good.

(Edit: this is the issue where I mentioned the above.)
#1181

@jasmussen
Copy link
Contributor

@paaljoachim is this the one? #1081

In any case, the idea is virtually the same, and I apologize for flip flopping on this. I do think it's valuable that we tried the "Continue writing" idea, though clearly that didn't work when we also had placeholder text. I will admit my mistakes ;)

@paaljoachim
Copy link
Contributor

We are all brain storming on ideas. One idea leads to the next..:) It all matures along the way.

dratwas pushed a commit that referenced this pull request Nov 14, 2019
Release 1.16.1

Android device tests look stuck so I'm moving the PR forward.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] In Progress Tracking issues with work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants