-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move "continue writing" next to inserter and show on hover. #1553
Conversation
mtias
commented
Jun 28, 2017
Another exploration: https://cloudup.com/cHelDRmdj11 |
I like the other exploration. The problem we want to solve is very specific: if a non-text block is the last block in the list, you should have an easier way to continue writing text, than to first have to click Insert > Text. The "Continue writing..." did this, though I agree perhaps not in an elegant way. Both solutions presented here address this also. In the past, ideas similar to your "other exploration" have been brought up. I can't recall the specific people who suggested it, but @shaunandrews and @paaljoachim come to mind. My concern back then was that this area below the inserter showed The fading out of everything but the plus, as well as the fact that there are only two blocks there — text and image — feels like it can address those concerns. In recognizing that I was probably wrong to disagree with the ideas presented by Shaun and Joachim (and maybe others) in the past, here's an acknowledgement that you were all probably on to something, and I was probably wrong. Therefore, thumbs up from me, provided this can be made accessible (if it isn't already, it possibly is), let's try this and iterate. |
8eb1e0b
to
7d15a80
Compare
Looks good in latest version! Remember to use |
Push failed :) |
I added the wireframe of having the image and text block show up when clicking/hovering the inserter as a way to avoid having the continue writing block show up. It would seem less intrusive on the user. I was not sure if I liked it or not, but Mathias exploration looks good. (Edit: this is the issue where I mentioned the above.) |
@paaljoachim is this the one? #1081 In any case, the idea is virtually the same, and I apologize for flip flopping on this. I do think it's valuable that we tried the "Continue writing" idea, though clearly that didn't work when we also had placeholder text. I will admit my mistakes ;) |
We are all brain storming on ideas. One idea leads to the next..:) It all matures along the way. |
Release 1.16.1 Android device tests look stuck so I'm moving the PR forward.