-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added optional 'description' prop to inspector controls #1570
Added optional 'description' prop to inspector controls #1570
Conversation
cc @afercia for a11y feedback |
For all the controls, except "radio", I'd consider to associate the description to the form element with an I'd consider to don't use italic text (I think I've mentioned this also in another issue for the few cases where it's used in Gutenberg) as it's not a consistent convention across WordPress and makes readability harder for some users. The description paragraph is a flex-item, not sure if it needs |
* Fixed an issue where the small description would wrap parallel to the toggle control.
@paulwilde, this PR needs rebase and some small tweaks. It looks like a nice improvement, so it would be nice to land it into master :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Marking that it requires a rebase to continue.
I'm closing this one because it seems to be abandoned. Feel free to update the code to work with the current codebase and reopen. Thanks for spending your time working on this PR. |
This adds an optional prop to all inspector controls to add description text below. Useful for help text.