Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge mobile v1.5.0 fixes into master #15703

Merged
merged 2 commits into from
May 20, 2019
Merged

Merge mobile v1.5.0 fixes into master #15703

merged 2 commits into from
May 20, 2019

Conversation

koke
Copy link
Contributor

@koke koke commented May 17, 2019

These have already been reviewed in #15685 and #15698

* RichText: ownProps has precedence over block context.
In this way, instances of RichText outside blocks can pass and handle their own custom onFocus and isSelected

* RichText: Remove isSelected from block edit context.

* Fix lint issues
Removing it generates a regression where inserting a new list block, the block is not selected
@koke koke added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label May 17, 2019
Copy link
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Let's not forget to create a rnmobile/release tag to not lose the commit referenced in gutenberg-mobile/master

@koke
Copy link
Contributor Author

koke commented May 20, 2019

It looks like you already created it, so merging this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants