Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update block attributes for clarification #15818

Merged
merged 2 commits into from
May 24, 2019
Merged

Update block attributes for clarification #15818

merged 2 commits into from
May 24, 2019

Conversation

mkaz
Copy link
Member

@mkaz mkaz commented May 24, 2019

Description

Edit introduction to attributes for clarification.

Move up the object keys section since it was lost in the hpq paragraph, also the keys are specified first, so better to mention them first.

Add example for using class as a selector

Types of changes

Documentation. View live on branch

Edit introduction to attributes for clarification.

Move up the object keys section since it was lost in the hpq paragraph,
also the keys are specified first, so better to mention them first.

Add example for using class as a selector
Copy link
Member

@jorgefilipecosta jorgefilipecosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me and I like this more direct writing style 👍 I left some suggestions as possible enhancements but I am not too certain about them so feel free to ignore the suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants