-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/image overlaps control #15966
Fix/image overlaps control #15966
Conversation
Hi @senadir, thank you for the pull request! This branch: Master: This is very nice, and it doesn't seem like the z-index change has any negative side effects. However I see a bunch of changes that seem to be related to the Date Picker component. Can you explain what those changes intend to accomplish? In general, it is good practice to keep pull requests as specific as possible and fix only one issue at a time. This makes reviews both easier and faster. Thanks again. |
That's a a really amature mistake from my side, those commits come from another pull request #15962 |
No worries. I still see a lot of calendar stuff in this PR, it's probably easiest to just edit that out of this PR rather than trying to revert individual commits. But once that's gone, we can put this in a milestone to review! Thanks again. |
e946658
to
82e90bb
Compare
@jasmussen the unrelated commits have been fixed so you can review again to merge |
@jasmussen after checking the conflict files it seems you already fixed this issue in #15537 and merged it 6 days ago. so I will close this PR since it's not needed |
Oh interesting, I must have unknowingly fixed it, so I very much appreciate you verifying that it fixes this issue. And thanks so much for the PR, really do appreciate it! |
closes issue #15923
Description
increase block editor contextual toolbar z index so that floated images don't overlap it
How has this been tested?
see #15923 for a way to reintroduce and then click on image to test
Screenshots
Types of changes
bug fix
Checklist: