Fix toolbars, polish inserter, inspector, lots of blocks #1597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Feature] Blocks
swissspidy
reviewed
Jun 30, 2017
| @@ -108,7 +109,11 @@ registerBlockType( 'core/heading', { | |||
| ), | |||
| focus && ( | |||
| <InspectorControls key="inspector"> | |||
| <h3>{ __( 'Heading Size' ) }</h3> | |||
| <BlockDescription> | |||
| <p>{ __( 'Search engines use the headings to index the structure and content of your web pages.' ) }</p> | |||
There was a problem hiding this comment.
Headings are great for readers too 🙂
There was a problem hiding this comment.
Hah, yes indeed. I think we'll actually want to go over those descriptions altogether, perhaps in a separate PR. The text description is a little jokey as is ;)
youknowriad
reviewed
Jun 30, 2017
| @@ -95,18 +96,29 @@ registerBlockType( 'core/cover-image', { | |||
| const sectionClasses = classnames( { | |||
| 'cover-image': true, | |||
| 'has-parallax': hasParallax, | |||
| 'has-background-dim': hasBackgroundDim, | |||
There was a problem hiding this comment.
We'd probably need to add this class to the save function too
youknowriad
reviewed
Jun 30, 2017
| @@ -10,6 +10,9 @@ | |||
| color: white; | |||
| font-size: 24pt; | |||
| line-height: 1em; | |||
| max-width: $visual-editor-max-width; | |||
| padding: $block-padding; | |||
| text-align: center; | |||
There was a problem hiding this comment.
I guess some of these are editor specific while the text-align might be shared with the frontend styling too.
This is just a note to take these considerations into account while rebasing.
youknowriad
approved these changes
Jun 30, 2017
jasmussen
force-pushed
the
fix/selected-blocks-other
branch
from
cf4d18d
to
809da72
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is sort of a "trash pickup" PR, and polishes a lot of small things:
BlockDescriptioncomponent by @swissspidy and applies it to all blocks with inspector controlsScreenshots: