-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Project management: Fix milestone version selection when RC is included in version #16084
Conversation
@@ -29,7 +29,7 @@ minor=${parts[1]} | |||
|
|||
# 3. Determine next milestone. | |||
|
|||
if [ minor == '9' ]; then | |||
if [[ $minor == 9* ]]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I followed: https://stackoverflow.com/a/2172367
I know little about bash :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 looks good! Using [[
syntax here is okay because our shebang is #!/bin/bash
and not #!/bin/sh
.
Hmm, it's strange to me that it'd be doing this, or at least that the proposed changes would have any impact. It should be reading from I'm also (pleasantly?) surprised the action has been working, since previously I'd been having issues with it always being "Cancelled". |
Or maybe it does fix the issue, but not because of the wildcard, and instead because of the difference between http://mywiki.wooledge.org/BashFAQ/031 Edit: Though, according to this one, they should be the "same" 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I get it now. The key is changing minor
to $minor
. Maybe my floundering is obvious to you as the author 😄 It seems it is the only necessary change, but I suppose there's no harm in the other (single to double square brackets, wildcard comparison).
Hmm, I no longer know if this is something that will fix the issue then. I tested it against |
That's not the fix, but these changes do resolve the issue. The issue comes from the fact that |
Description
The current version of the plugin is
5.9-rc.1
. This causes thatMilestone it
action creates Gutenberg 5.10 milestone where it should createGutenberg 6.0
. I fixed manually some of the latest PRs merged to be assigned to the correct milestone but we need to fix in in the actions as well.