Makes cleanForSlug more robust when receiving falsy values. #16236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
added
the
First-time Contributor
gziolo
reviewed
Jun 22, 2019
gziolo
added
[Package] Editor
|
Added a unit test as well 🚀 |
gziolo
approved these changes
Jun 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes https://core.trac.wordpress.org/ticket/47216
Currently, cleanForSlug is used a few times with the assumption that it'll return a falsy value for a falsy input (see post-link or post-permalink) but it crashes as it assumes the argument to be string.
How has this been tested?
I ran this change in a local WordPress instance with the testing procedure outlined in the WordPress issue.
Types of changes
Bug fix.
Checklist: