-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to skip NVM installation in setup-local-env.sh #16248
Allow to skip NVM installation in setup-local-env.sh #16248
Conversation
Reviewers' Note: Hide whitespace changes while reviewing. It will help to understand the new change in better way. |
case "${opt}" in | ||
-) | ||
case "${OPTARG}" in | ||
skip-nvm-setup) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Open to suggestions on renaming this flag name.
This change breaks Travis jobs causing them to run forever, see: |
This was not needed, as each script is sourced explicitly in the current shell. So it will take its own arguments. This will also fix the Travis CI timeout.
First commit was indeed a genuine mistake from my side and the build was failing because of that. But last 2 builds doesn't look like relevant failures. In first, an e2e test failed and in second, a unit test failed. I am not able to conclude a straight forward reason, why they would fail due to my changes, which are essentially targeted towards build tooling and local development. Can someone have a second look? 👀 |
Merged latest master into my branch and now tests are passing without any changes from my end. Should be good to review now. |
cc @pento does this sound like something we might want to have? |
nvm is not really a standard to check or install node versions, I'd personally just remove all nvm related scripts... and just check if the node version is not right, ask the person to install the right one with its preferred method. |
Yah, NVM was an interesting experiment in trying to ensure the correct version of Node was installed, but I don't think it was a successful as I would've liked. #17004 will remove all of these scripts, so I'm going to close this PR in favour of that one. |
Description
Related to #9120.
I'm using nodenv as Node Version Manager. So it's conflicting with the NVM setup script in
./setup-local-env.sh
.This PR introduces a flag option for the
setup-local-env.sh
script to skip NVM installation and setup, if needed. By default, it will behave as is.How has this been tested?
./bin/setup-local-env.sh --skip-nvm-setup
on the local machine will skip all the steps related to NVM, and directly installnpm
packages.getopts
which seems to be in-built command in bash. So hopefully, it also works in Windows/Linux. Happy to listen from other OS users.Types of changes
Checklist: