-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update re-resizable dependency to the last version #16325
Conversation
@@ -40,7 +40,7 @@ | |||
"memize": "^1.0.5", | |||
"moment": "^2.22.1", | |||
"mousetrap": "^1.6.2", | |||
"re-resizable": "^4.7.1", | |||
"re-resizable": "^5.0.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm curious on what caused this, but nice to see that we only needed a package bump here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried looking at the changelog, but I'm uncertain what caused it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
renovate has a really nice package diff tool now that can help when the changelog is less than forthcoming: https://renovatebot.com/package-diff?name=re-resizable&from=4.7.1&to=5.0.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Though in this case... a lot changed :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice I didn't know about that tool. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @youknowriad, I think this resolves the Chrome rendering bug with resizable images in containers.
I tested this with Chrome/FF at various browser widths with the columns + media+text block
This seems to fix the issues related to the Media & Text block causing the editor to only show half of the canvas.
This issue was also seen with the columns and image blocks, not sure if this fixes these as well.
closes #14652