Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update re-resizable dependency to the last version #16325

Merged
merged 1 commit into from
Jun 27, 2019

Conversation

youknowriad
Copy link
Contributor

This seems to fix the issues related to the Media & Text block causing the editor to only show half of the canvas.

This issue was also seen with the columns and image blocks, not sure if this fixes these as well.

closes #14652

@youknowriad youknowriad added the [Type] Bug An existing feature does not function as intended label Jun 27, 2019
@youknowriad youknowriad self-assigned this Jun 27, 2019
@mtias mtias added the [Feature] UI Components Impacts or related to the UI component system label Jun 27, 2019
@@ -40,7 +40,7 @@
"memize": "^1.0.5",
"moment": "^2.22.1",
"mousetrap": "^1.6.2",
"re-resizable": "^4.7.1",
"re-resizable": "^5.0.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious on what caused this, but nice to see that we only needed a package bump here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried looking at the changelog, but I'm uncertain what caused it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

renovate has a really nice package diff tool now that can help when the changelog is less than forthcoming: https://renovatebot.com/package-diff?name=re-resizable&from=4.7.1&to=5.0.1

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though in this case... a lot changed :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice I didn't know about that tool. 👍

Copy link
Contributor

@gwwar gwwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @youknowriad, I think this resolves the Chrome rendering bug with resizable images in containers.

I tested this with Chrome/FF at various browser widths with the columns + media+text block

Before:
before

After:
after

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] UI Components Impacts or related to the UI component system [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resizing Media & Text block can cause half of the editor to appear blank
4 participants