Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RNMobile] Show "add block here" placeholder when adding block from title #16539

Merged
merged 1 commit into from
Jul 19, 2019

Conversation

mchowning
Copy link
Contributor

Description

Fixes issue where the "add block here" indicator was not shown if the new block was being added while the post's title is selected.

How has this been tested?

See related mobile-gutenberg PR

Types of changes

Non-breaking change to fix a bug.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@mchowning mchowning added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Jul 11, 2019
@mchowning mchowning requested review from Tug and marecar3 July 11, 2019 13:58
@mchowning mchowning self-assigned this Jul 11, 2019
Copy link
Contributor

@marecar3 marecar3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @mchowning ! 🎉
I think that we are good to go with this one!

@mchowning mchowning merged commit 6ef0222 into master Jul 19, 2019
@mchowning mchowning deleted the rnmobile/show_add_block_placeholder_from_title branch July 19, 2019 10:28
@youknowriad youknowriad added this to the Gutenberg 6.2 milestone Jul 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants