Framework: Restrict combineReducers usage to data module #16752
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request seeks to replace a reference to Redux's
combineReducers
in@wordpress/core-data
with the equivalent utility exported from@wordpress/data
. In so doing, it includes a new project-level ESLint syntax restriction to enforce this usage. The proposed benefit of this change is to ensure consistency, leverage performance benefits from #11255, and avoid bundling multiple copies of acombineReducers
utility. Furthermore, thecore-data
package never defined an explicit dependency onredux
and thus was only incidentally able to be built without errors.Testing Instructions:
Ensure unit tests pass:
Ensure lint passes: