Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framework: Restrict combineReducers usage to data module #16752

Merged
merged 2 commits into from
Jul 25, 2019
Merged

Conversation

aduth
Copy link
Member

@aduth aduth commented Jul 25, 2019

This pull request seeks to replace a reference to Redux's combineReducers in @wordpress/core-data with the equivalent utility exported from @wordpress/data. In so doing, it includes a new project-level ESLint syntax restriction to enforce this usage. The proposed benefit of this change is to ensure consistency, leverage performance benefits from #11255, and avoid bundling multiple copies of a combineReducers utility. Furthermore, the core-data package never defined an explicit dependency on redux and thus was only incidentally able to be built without errors.

Testing Instructions:

Ensure unit tests pass:

npm run test-unit

Ensure lint passes:

npm run lint-js

@aduth aduth added [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Type] Code Quality Issues or PRs that relate to code quality [Package] Core data /packages/core-data labels Jul 25, 2019
@aduth aduth requested review from nerrad and youknowriad as code owners July 25, 2019 14:58
Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@aduth aduth merged commit bd4c495 into master Jul 25, 2019
@aduth aduth deleted the remove/redux branch July 25, 2019 15:41
@youknowriad youknowriad added this to the Gutenberg 6.2 milestone Jul 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Core data /packages/core-data [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants