Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Clear floats on specific successive blocks that use alignment tool #16780

Closed
wants to merge 3 commits into from
Closed

Fix: Clear floats on specific successive blocks that use alignment tool #16780

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bd086b9
Fixes 13784
codetipi Feb 11, 2019
6e91eaf
More opinionated tweak to make center aligned blocks clear floats (si…
codetipi Feb 12, 2019
b69baaf
Remove extra line
obenland Jul 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/block-editor/src/components/block-list/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,6 +411,11 @@
}
}

// Center
&[data-align="center"] {
clear: both;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still have the same question, not sure if it was answered. This behavior only applies to the editor, do we want to apply the same behavior in the frontend too?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it makes sense to have the same behavior right?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does for me 🤷‍♂ but maybe we're expecting the theme to define that?


// Wide and full-wide
&[data-align="full"],
&[data-align="wide"] {
Expand Down