Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Fix changelog version information #16908

Merged
merged 1 commit into from
Aug 5, 2019
Merged

Docs: Fix changelog version information #16908

merged 1 commit into from
Aug 5, 2019

Conversation

sirreal
Copy link
Member

@sirreal sirreal commented Aug 5, 2019

Description

Updates the changelog to correctly include information about which package version includes the changes from #15120.

You can verify that v2.1 does not include the changes and version v2.2 does:

https://unpkg.com/@wordpress/babel-plugin-import-jsx-pragma@2.1.0/index.js
https://unpkg.com/@wordpress/babel-plugin-import-jsx-pragma@2.2.0/index.js

How has this been tested?

No testing, docs only.

Types of changes

n/a

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@sirreal sirreal added the [Tool] Babel plugin import JSX pragma /packages/babel-plugin-import-jsx-pragma label Aug 5, 2019
@sirreal sirreal requested a review from gziolo August 5, 2019 18:13
@sirreal sirreal self-assigned this Aug 5, 2019
@sirreal sirreal added [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later [Type] Developer Documentation Documentation for developers labels Aug 5, 2019
gziolo
gziolo approved these changes Aug 5, 2019
View reviewed changes
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clarifying that. I wrongly assumed that all unreleased changes come from the last release. It was missed a while back.

@gziolo gziolo merged commit 1fcc646 into master Aug 5, 2019
@gziolo gziolo deleted the fix/jsx-package-changelog-version branch August 5, 2019 19:46
@gziolo gziolo added this to the Gutenberg 6.3 milestone Aug 5, 2019
gziolo pushed a commit that referenced this pull request Aug 29, 2019
@sirreal @gziolo
Fix changelog date (#16908)
6963ce1
gziolo pushed a commit that referenced this pull request Aug 29, 2019
@sirreal @gziolo
Fix changelog date (#16908)
584e5a6
@snyk-io snyk-io bot mentioned this pull request Aug 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gziolo gziolo gziolo approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@nerrad nerrad Awaiting requested review from nerrad

@ntwb ntwb Awaiting requested review from ntwb

Assignees

@sirreal sirreal

Labels
[Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later [Tool] Babel plugin import JSX pragma /packages/babel-plugin-import-jsx-pragma [Type] Developer Documentation Documentation for developers
Projects
None yet
Milestone
Gutenberg 6.3
Development

Successfully merging this pull request may close these issues.
2 participants
@sirreal @gziolo